Update Analyzer.scala

apache · Sep 1, 2020 · 84e65af · 84e65af
1 parent 51cea07
commit 84e65af
Showing 1 changed file with 14 additions and 15 deletions.
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
@@ -1456,11 +1456,7 @@ class Analyzer(
 
         val resolvedGroupingExprs = a.groupingExpressions
           .map(resolveExpressionTopDown(_, planForResolve, trimAlias = true))
-          .map {
-            // trim Alias over top-level GetStructField
-            case Alias(s: GetStructField, _) => s
-            case other => other
-          }
+          .map(trimTopLevelGetStructFieldAlias)
 
         val resolvedAggExprs = a.aggregateExpressions
           .map(resolveExpressionTopDown(_, planForResolve, trimAlias = true))
@@ -1471,19 +1467,11 @@ class Analyzer(
       case g: GroupingSets =>
         val resolvedSelectedExprs = g.selectedGroupByExprs
           .map(_.map(resolveExpressionTopDown(_, g, trimAlias = true))
-            .map {
-              // trim Alias over top-level GetStructField
-              case Alias(s: GetStructField, _) => s
-              case other => other
-            })
+            .map(trimTopLevelGetStructFieldAlias))
 
         val resolvedGroupingExprs = g.groupByExprs
           .map(resolveExpressionTopDown(_, g, trimAlias = true))
-          .map {
-            // trim Alias over top-level GetStructField
-            case Alias(s: GetStructField, _) => s
-            case other => other
-          }
+          .map(trimTopLevelGetStructFieldAlias)
 
         val resolvedAggExprs = g.aggregations
           .map(resolveExpressionTopDown(_, g, trimAlias = true))
@@ -1585,6 +1573,17 @@ class Analyzer(
       AttributeSet(projectList.collect { case a: Alias => a.toAttribute })
     }
 
+    // This method is used to trim groupByExpressions/selectedGroupByExpressions's top-level
+    // GetStructField Alias. Since these expression are not NamedExpression originally,
+    // we are safely to trim top-level GetStructField Alias.
+    def trimTopLevelGetStructFieldAlias(e: Expression): Expression = {
+      e match {
+        // trim Alias over top-level GetStructField
+        case Alias(s: GetStructField, _) => s
+        case other => other
+      }
+    }
+
     /**
      * Build a project list for Project/Aggregate and expand the star if possible
      */