Skip to content

Commit

Permalink
Fix issue in 'docker-image-tool.sh'
Browse files Browse the repository at this point in the history
Because of the missing assignment of the variable `BUILD_ARGS` the command `./bin/docker-image-tool.sh -r docker.io/myrepo -t v2.3.1 build` fails:

```
docker build" requires exactly 1 argument.
See 'docker build --help'.

Usage:  docker build [OPTIONS] PATH | URL | - [flags]

Build an image from a Dockerfile
```

This has been fixed on the `master` already but, apparently, it has not been ported back to the branch `2.3`, leading to the same error even on the latest `2.3.1` release (dated 8 June 2018).

Author: Fabrizio Cucci <[email protected]>

Closes #21551 from fabriziocucci/patch-1.
  • Loading branch information
fabriziocucci authored and mccheah committed Jun 18, 2018
1 parent 9d63e54 commit b8dbfcc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions bin/docker-image-tool.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ function build {
else
# Not passed as an argument to docker, but used to validate the Spark directory.
IMG_PATH="kubernetes/dockerfiles"
BUILD_ARGS=()
fi

if [ ! -d "$IMG_PATH" ]; then
Expand Down

0 comments on commit b8dbfcc

Please sign in to comment.