-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12902] [SQL] visualization for generated operators #10828
Conversation
cc @zsxwing |
This is pretty cool. |
Test build #49670 has finished for PR 10828 at commit
|
Test build #2412 has finished for PR 10828 at commit
|
@davies did you check if the history server displays this correctly? |
Just tried it in the history server and it worked correctly. Nice! |
@@ -20,6 +20,12 @@ | |||
text-shadow: none; | |||
} | |||
|
|||
#plan-viz-graph svg g.cluster rect { | |||
fill: #E5F2ff; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use a different style? I think we should make the UI stuff consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one will you suggest? This is outer of operator, should be lighter than that, I choose this because it's between white and the one used for operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the inconsistent style. |
@zsxwing Updated, check that again. |
LGTM pending tests |
Test build #2421 has finished for PR 10828 at commit
|
retest this please |
Test build #49803 has finished for PR 10828 at commit
|
Test build #2423 has finished for PR 10828 at commit
|
retest this please |
Test build #2424 has finished for PR 10828 at commit
|
Test build #2425 has finished for PR 10828 at commit
|
Test build #49825 has finished for PR 10828 at commit
|
Test build #49812 has finished for PR 10828 at commit
|
Test build #2426 has finished for PR 10828 at commit
|
Test build #2427 has finished for PR 10828 at commit
|
Test build #2428 has finished for PR 10828 at commit
|
Test build #2430 has finished for PR 10828 at commit
|
Test build #2434 has finished for PR 10828 at commit
|
Test build #2435 has finished for PR 10828 at commit
|
Test build #2446 has finished for PR 10828 at commit
|
Test build #2455 has finished for PR 10828 at commit
|
It passed finally, bingo! Merging this into master, thanks! |
This PR brings back visualization for generated operators, they looks like:
Note: SQL metrics are not supported right now, because they are very slow, will be supported once we have batch mode.