-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-12932] [Java API] improved error message for java type inference failure #10865
Conversation
(Link this to your JIRA -- see guidance here first for how to open a PR: https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark ) |
Test build #2432 has finished for PR 10865 at commit
|
cc @cloud-fan |
@@ -406,7 +406,7 @@ object JavaTypeInference { | |||
expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil | |||
}) | |||
} else { | |||
throw new UnsupportedOperationException(s"no encoder found for ${other.getName}") | |||
throw new UnsupportedOperationException(s"Cannot infer type for Java class ${other.getName} because it is not bean-compliant") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be less than 100 chars wide to fit spark's style guide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have pushed a fix.
On Thu, Jan 21, 2016 at 8:12 PM, Reynold Xin [email protected]
wrote:
In
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/JavaTypeInference.scala
#10865 (comment):@@ -406,7 +406,7 @@ object JavaTypeInference {
expressions.Literal(fieldName) :: extractorFor(fieldValue, fieldType) :: Nil
})
} else {
throw new UnsupportedOperationException(s"no encoder found for ${other.getName}")
throw new UnsupportedOperationException(s"Cannot infer type for Java class ${other.getName} because it is not bean-compliant")
this needs to be less than 100 chars wide to fit spark's style guide
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/10865/files#r50498058.
LGTM |
Test build #2436 has finished for PR 10865 at commit
|
Test build #2440 has finished for PR 10865 at commit
|
Test build #2441 has finished for PR 10865 at commit
|
Test build #2442 has finished for PR 10865 at commit
|
Looks like there are some test failures? |
Test build #2444 has finished for PR 10865 at commit
|
Yeah, these are consistent test failures but they're not due to this change. |
looks like it's related to the jenkins machine that run this test? |
Jenkins, retest this please. |
Test build #49980 has finished for PR 10865 at commit
|
Merged to master/1.6 |
…e failure Author: Andy Grove <[email protected]> Closes #10865 from andygrove/SPARK-12932. (cherry picked from commit d8e4805) Signed-off-by: Sean Owen <[email protected]>
No description provided.