[SPARK-12901][SQL] Refactor options for JSON and CSV datasource (not case class and same format). #10895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #49977 has finished for PR 10895 at commit
|
|
Thanks - I've merged this. |
|
@HyukjinKwon If you get a chance, can you fit the scala compilation. |
|
|
||
| private[sql] case class CSVParameters(@transient parameters: Map[String, String]) extends Logging { | ||
| private[sql] class CSVOptions( | ||
| @transient parameters: Map[String, String]) |
There was a problem hiding this comment.
I think you need @transient private val at here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yep, that's the right fix.
|
I have pushed 00026fa to fix the 2.11 build. |
|
Sorry, I just checked this notification. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-12901
This PR refactors the options in JSON and CSV datasources.
In more details,
JSONOptionsuses the same format asCSVOptions.CSVRelationthat does not have to be serializable (it waswith Serializablebut I removed)