[SPARK-13916][SQL] Add a metric to WholeStageCodegen to measure duration. #11741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. WholeStageCodegen naturally breaks the execution into pipelines that are easier to measure duration. This is more granular than the task timings (a task can be multiple pipelines) and is integrated with the web ui.
|
Test build #53220 has finished for PR 11741 at commit
|
|
Test build #53222 has finished for PR 11741 at commit
|
|
Test build #53465 has finished for PR 11741 at commit
|
| @@ -34,6 +34,7 @@ | |||
| protected LinkedList<InternalRow> currentRows = new LinkedList<>(); | |||
| // used when there is no column in output | |||
| protected UnsafeRow unsafeRow = new UnsafeRow(0); | |||
| private long startTimeMs = System.currentTimeMillis(); | |||
There was a problem hiding this comment.
we should use nanoTime. See https://github.com/databricks/scala-style-guide#misc_currentTimeMillis_vs_nanoTime
|
Test build #53716 has finished for PR 11741 at commit
|
|
LGTM |
|
Test build #53717 has finished for PR 11741 at commit
|
|
Merging in master. Thanks. |
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…ion. ## What changes were proposed in this pull request? WholeStageCodegen naturally breaks the execution into pipelines that are easier to measure duration. This is more granular than the task timings (a task can be multiple pipelines) and is integrated with the web ui. We currently report total time (across all tasks), min/mask/median to get a sense of how long each is taking. ## How was this patch tested? Manually tested looking at the web ui. Author: Nong Li <[email protected]> Closes apache#11741 from nongli/spark-13916.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
WholeStageCodegen naturally breaks the execution into pipelines that are easier to
measure duration. This is more granular than the task timings (a task can be multiple
pipelines) and is integrated with the web ui.
We currently report total time (across all tasks), min/mask/median to get a sense of how long each is taking.
How was this patch tested?
Manually tested looking at the web ui.