[SPARK-14007] [SQL] Manage the memory used by hash map in shuffled hash join #11826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 18, 2016 10:41
|
Test build #53546 has finished for PR 11826 at commit
|
davies
changed the title
|
Test build #53547 has finished for PR 11826 at commit
|
|
Test build #2652 has finished for PR 11826 at commit
|
|
cc @rxin |
|
cc @sameeragarwal for review |
| val copiedIter = iter.map { row => | ||
| // It's hard to guess what's exactly memory will be used, we have a raft guess here. | ||
| // TODO: use BytesToBytesMap instead of HashMap for memory efficiency | ||
| val needed = 150 + row.getSizeInBytes |
There was a problem hiding this comment.
Can you please explain (and possibly comment in code) the reason behind choosing 150?
|
LGTM, just one clarifying question. |
|
Merging this into master. |
|
Test build #53695 has finished for PR 11826 at commit
|
| val got = memoryManager.acquireExecutionMemory( | ||
| Math.max(memoryManager.pageSizeBytes(), needed), MemoryMode.ON_HEAP, null) | ||
| if (got < needed) { | ||
| throw new SparkException("Can't acquire enough memory to build hash map in shuffled" + |
There was a problem hiding this comment.
nit: missing space between shuffled and hash
roygao94
pushed a commit
to roygao94/spark
that referenced
this pull request
Mar 22, 2016
…sh join ## What changes were proposed in this pull request? This PR try acquire the memory for hash map in shuffled hash join, fail the task if there is no enough memory (otherwise it could OOM the executor). It also removed unused HashedRelation. ## How was this patch tested? Existing unit tests. Manual tests with TPCDS Q78. Author: Davies Liu <[email protected]> Closes apache#11826 from davies/cleanup_hash2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR try acquire the memory for hash map in shuffled hash join, fail the task if there is no enough memory (otherwise it could OOM the executor).
It also removed unused HashedRelation.
How was this patch tested?
Existing unit tests. Manual tests with TPCDS Q78.