Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-14058][PYTHON] Incorrect docstring in Window.order #11877

Closed
wants to merge 1 commit into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Mar 22, 2016

What changes were proposed in this pull request?

Replaces current docstring ("Creates a :class:WindowSpec with the partitioning defined.") with "Creates a :class:WindowSpec with the ordering defined."

How was this patch tested?

PySpark unit tests (no regression introduced). No changes to the code.

@rxin
Copy link
Contributor

rxin commented Mar 22, 2016

Thanks - merging this in master and branch-1.6.

asfgit pushed a commit that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

Replaces current docstring ("Creates a :class:`WindowSpec` with the partitioning defined.") with "Creates a :class:`WindowSpec` with the ordering defined."

## How was this patch tested?

PySpark unit tests (no regression introduced). No changes to the code.

Author: zero323 <[email protected]>

Closes #11877 from zero323/order-by-description.

(cherry picked from commit 8193a26)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 8193a26 Mar 22, 2016
@SparkQA
Copy link

SparkQA commented Mar 22, 2016

Test build #53750 has finished for PR 11877 at commit c4e505b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

roygao94 pushed a commit to roygao94/spark that referenced this pull request Mar 22, 2016
## What changes were proposed in this pull request?

Replaces current docstring ("Creates a :class:`WindowSpec` with the partitioning defined.") with "Creates a :class:`WindowSpec` with the ordering defined."

## How was this patch tested?

PySpark unit tests (no regression introduced). No changes to the code.

Author: zero323 <[email protected]>

Closes apache#11877 from zero323/order-by-description.
@zero323 zero323 deleted the order-by-description branch April 6, 2017 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants