[SPARK-14123] [SQL] DDL: Create / Drop Function #11988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| databaseName | ||
| } else { | ||
| Some(catalog.getCurrentDatabase) | ||
| } |
There was a problem hiding this comment.
val db = databaseName.getOrElse(catalog.getCurrentDatabase)Then, use Some in the next statement.
|
@bomeng Overall, looks good. Just a few minor comments. Can you also emphasize the following point in the
BTW, this PR also needs to wait for the merge of PR: #11972. We need to do the corresponding changes based on it. Thanks for your fast work! cc @yhuai @andrewor14 Could you check if this solution is appropriate? Thanks! |
|
Hive tests failed. Closed for now for more investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is the first step to support create / drop functions by using catalog based on @yhuai document. Instead of using NativeDDLCommand, we will call the functions in the catalog to do the jobs.
How was this patch tested?
I've create a new test suite called DDLSuite that will test the DDL functions, eventually it will contains more DDL test cases, such as Create DB / Table, etc.