Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved GraphX PageRank Test Coverage #1228

Closed
wants to merge 2 commits into from
Closed

Improved GraphX PageRank Test Coverage #1228

wants to merge 2 commits into from

Conversation

jegonzal
Copy link
Contributor

This PR adds additional tests that identify a bug in the current implementation of staticPagerank. This bug is addressed in #1217.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@jegonzal
Copy link
Contributor Author

@ankurdave thanks for pointing out this bug!

@AmplabJenkins
Copy link

Merged build finished.

@AmplabJenkins
Copy link

Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16151/

@mateiz
Copy link
Contributor

mateiz commented Aug 27, 2014

Jenkins, test this please

@mateiz
Copy link
Contributor

mateiz commented Aug 27, 2014

test this please

@SparkQA
Copy link

SparkQA commented Aug 27, 2014

QA tests have started for PR 1228 at commit 487c968.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 27, 2014

QA tests have finished for PR 1228 at commit 487c968.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@mateiz
Copy link
Contributor

mateiz commented Aug 27, 2014

@jegonzal seems like these GraphX tests actually fail -- any ideas what's going on?

@jegonzal
Copy link
Contributor Author

Yes. This is an extension of the unit tests to catch a class of bugs addressed in PR #1217 (which has not been merged). I believe @ankurdave was working on a merge of these two pull requests.

@SparkQA
Copy link

SparkQA commented Sep 5, 2014

Can one of the admins verify this patch?

@jegonzal
Copy link
Contributor Author

This should now be addressed in the latest master and does not depend on PR #1217

@jegonzal
Copy link
Contributor Author

ok to test

@ankurdave
Copy link
Contributor

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Nov 7, 2014

Test build #23072 has started for PR 1228 at commit 8498483.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 7, 2014

Test build #23072 has finished for PR 1228 at commit 8498483.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PageRankSuite extends FunSuite with LocalSparkContext with Matchers

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23072/
Test PASSed.

@jegonzal
Copy link
Contributor Author

@ankurdave and @rxin can we merge this now?

@SparkQA
Copy link

SparkQA commented Dec 9, 2014

Test build #24257 has started for PR 1228 at commit 8498483.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 9, 2014

Test build #24257 has finished for PR 1228 at commit 8498483.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class PageRankSuite extends FunSuite with LocalSparkContext with Matchers

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24257/
Test PASSed.

@srowen
Copy link
Member

srowen commented May 18, 2015

@jegonzal cleaning house a bit -- this is the oldest oustanding PR. Are you proceeding with it?

@jegonzal
Copy link
Contributor Author

I think we have covered most of this code in later tests (PR #1217) and the remaining tests need to be substantially updated which I can do in a later PR. I am going to go ahead and close this one. Sorry about the delay.

@jegonzal jegonzal closed this May 18, 2015
sunchao pushed a commit to sunchao/spark that referenced this pull request Dec 8, 2021
@aokolnychyi
[SPARK-35801][SQL] Add connector APIs for row-level operations (apach…
51037e2 
…e#1228)

### What changes were proposed in this pull request?

This PR adds connector APIs for DELETE/UPDATE/MERGE operations. It is similar to what we had in 3.1 but with changes to support merge-on-read per [this](https://docs.google.com/document/d/12Ywmc47j3l2WF4anG5vL4qlrhT2OKigb7_EbIKhxg60/) design doc.

### Why are the changes needed?

These changes are needed to support DELETE/UPDATE/MERGE operations.

### Does this PR introduce _any_ user-facing change?

This PR adds isolated connector APIs that will be used only by Iceberg.

### How was this patch tested?

Local testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jegonzal @AmplabJenkins @mateiz @SparkQA @ankurdave @srowen