SPARK-2482: Resolve sbt warnings during build

[witgo]

At the same time, import the scala.language.postfixOps and org.scalatest.time.SpanSugar._ cause scala.language.postfixOps doesn't work

[AmplabJenkins]

Merged build triggered.

[AmplabJenkins]

Merged build started.

[vanzin]

LGTM if tests pass.

[srowen]

Were all of those imports being removed not required after all to avoid warnings? as long as that's the case (i.e. no build warnings) yes this is great IMHO.

[AmplabJenkins]

Merged build finished. All automated tests passed.

[AmplabJenkins]

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16410/

[pwendell]

Jenkins, retest this pleae.

[pwendell]

Jenkins, retest this please.

[SparkQA]

QA tests have started for PR 1330. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16690/consoleFull

[pwendell]

Could you paste exactly which warnings you are eliminating? I don't see any warnings in our master jenkins build that seem relevant to these changes.

[witgo]

As a result of #772. The master has fixed this problem. But we should remove this line <arg>-language:postfixOps</arg> in pom.xml#L807. Once we remove this line.The problem will be back.
May have a look the discussion in #1069

[SparkQA]

QA tests have started for PR 1330. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16702/consoleFull

[SparkQA]

QA results for PR 1330:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/16702/consoleFull

[SparkQA]

QA tests have started for PR 1330. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17855/consoleFull

[SparkQA]

QA results for PR 1330:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17855/consoleFull

[andrewor14]

test this please

[srowen]

This is a sort of duplicate of #1069 @witgo this was opened a few times?

From the discussion, I am not clear this should be committed. The preferred practice here seems to be to import scala.language.postfixOps rather than use a compiler flag. This does the opposite.

In fact the compiler flag -language:postfixOps should be removed, which would then make these imports being removed important.

[witgo]

@andrewor14 , @srowen
This is mainly to solve the problem of importing the scala.language.postfixOps and org.scalatest.time.SpanSugar._ at the same time.

[SparkQA]

QA tests have started for PR 1330 at commit 15d5ed3.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 1330 at commit 15d5ed3.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • protected trait YarnAllocateResponse

[jkbradley]

@witgo Hi, I was asked to take a look at this PR. I tested the current master vs. this PR merged with the master, and I actually found that this PR added postfix warnings for me. (No postfix warnings in the master, but several with this PR.) Could you please show the warnings you get, plus info on what might be causing those warnings on your system? Thanks!

[witgo]

The code has been updated.

[witgo]

@jkbradley I removed this parameter. The related discussion in #1069

[SparkQA]

QA tests have started for PR 1330 at commit 179ba61.

• This patch merges cleanly.

[SparkQA]

QA tests have finished for PR 1330 at commit 179ba61.

• This patch passes unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[srowen]

The net-net change for all of these overlapping PRs should be: remove the compiler flag, and, add the import everywhere that the warning occurs. If there are warnings after this PR, they need to be squashed with more imports.

[witgo]

No postfix warnings in 179ba61 .

[jkbradley]

@witgo Sorry, I had not realized that this had not been updated since the discussions. Just tested it, and it worked for me. LGTM

[andrewor14]

Ok, I am merging this over the alternative PR #1323, which is now closed. Thanks to everyone who looked at this.