Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mesos] expand coarse-grained mode docs #14059

Closed
wants to merge 2 commits into from

Conversation

mgummelt
Copy link
Contributor

@mgummelt mgummelt commented Jul 5, 2016

What changes were proposed in this pull request?

docs

How was this patch tested?

viewed the docs in github

@mgummelt mgummelt changed the title expand coarse-grained mode expand coarse-grained mode docs Jul 5, 2016
@mgummelt
Copy link
Contributor Author

mgummelt commented Jul 5, 2016

I've added clarity to the coarse-grained mode documentation, as well as fixed some inconsistencies it had with the new Mesos scheduler

@mgummelt mgummelt changed the title expand coarse-grained mode docs [Mesos] expand coarse-grained mode docs Jul 5, 2016
@SparkQA
Copy link

SparkQA commented Jul 5, 2016

Test build #61797 has finished for PR 14059 at commit 2daaedb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@holdenk
Copy link
Contributor

holdenk commented Jul 5, 2016

Even for small doc changes it can be useful (to speed up review) to verify that the docs build as expected and mention that under tests.

@mgummelt
Copy link
Contributor Author

mgummelt commented Jul 5, 2016

I added that I've verified the docs render correctly in github


The benefit of coarse-grained mode is much lower startup overhead, but
at the cost of reserving Mesos resources for the complete duration of
the application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

say a word about dynamic allocation?\

@rxin
Copy link
Contributor

rxin commented Jul 6, 2016

LGTM except the minor comment.

requirements like interactive queries or serving web requests.
Spark can run over Mesos in two modes: "coarse-grained" (default) and
"fine-grained".

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coarse-Grained Mode

@mgummelt
Copy link
Contributor Author

mgummelt commented Jul 6, 2016

@rxin ready for merge. Would also like this in the 2.0 branch if possible.

@SparkQA
Copy link

SparkQA commented Jul 6, 2016

Test build #61868 has finished for PR 14059 at commit e97f63d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.


## Fine-Grained

In "fine-grained" mode, each Spark task inside the Spark executor runs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a message saying this is deprecated as of spark 2.0?

Copy link
Contributor Author

@mgummelt mgummelt Jul 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made a separate PR for that: #14078

Does that work?

Also, will this be merged into Spark 2.0.0? I need to make the copy consistent with the version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup both should go into 2.0.

@rxin
Copy link
Contributor

rxin commented Jul 6, 2016

Maybe we raced. I'm going to merge this one first and merge your deprecation one later.

merging in master/2.0.

@asfgit asfgit closed this in 9c04199 Jul 6, 2016
asfgit pushed a commit that referenced this pull request Jul 6, 2016
## What changes were proposed in this pull request?

docs

## How was this patch tested?

viewed the docs in github

Author: Michael Gummelt <[email protected]>

Closes #14059 from mgummelt/coarse-grained.

(cherry picked from commit 9c04199)
Signed-off-by: Reynold Xin <[email protected]>
asfgit pushed a commit that referenced this pull request Jul 9, 2016
## What changes were proposed in this pull request?

Documentation changes to indicate that fine-grained mode is now deprecated.  No code changes were made, and all fine-grained mode instructions were left in place.  We can remove all of that once the deprecation cycle completes (Does Spark have a standard deprecation cycle?  One major version?)

Blocked on #14059

## How was this patch tested?

Viewed in Github

Author: Michael Gummelt <[email protected]>

Closes #14078 from mgummelt/deprecate-fine-grained.

(cherry picked from commit b1db26a)
Signed-off-by: Reynold Xin <[email protected]>
asfgit pushed a commit that referenced this pull request Jul 9, 2016
## What changes were proposed in this pull request?

Documentation changes to indicate that fine-grained mode is now deprecated.  No code changes were made, and all fine-grained mode instructions were left in place.  We can remove all of that once the deprecation cycle completes (Does Spark have a standard deprecation cycle?  One major version?)

Blocked on #14059

## How was this patch tested?

Viewed in Github

Author: Michael Gummelt <[email protected]>

Closes #14078 from mgummelt/deprecate-fine-grained.
@mgummelt mgummelt deleted the coarse-grained branch August 2, 2016 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants