SPARK-1478.2 Fix incorrect NioServerSocketChannelFactory constructor call #1466
Conversation
…nstructor as the no-arg version, which is not even present in some versions of Netty
|
QA tests have started for PR 1466. This patch merges cleanly. |
| channelFactory, | ||
| channelPipelieFactory, | ||
| channelFactory, | ||
| channelPipelineFactory, |
There was a problem hiding this comment.
What changed here? Was there a formatting issue?
There was a problem hiding this comment.
There was a typo in the variable name. The other line was just the IDE
stripping a trailing space I think.
On Jul 17, 2014 7:52 PM, "Tathagata Das" [email protected] wrote:
In
external/flume/src/main/scala/org/apache/spark/streaming/flume/FlumeInputDStream.scala:new NettyServer( responder, new InetSocketAddress(host, port),
channelFactory,channelPipelieFactory,channelFactory,channelPipelineFactory,What changed here? Was there a formatting issue?
—
Reply to this email directly or view it on GitHub
https://github.com/apache/spark/pull/1466/files#r15076612.
|
QA results for PR 1466: |
|
Merging this, thanks Sean for the good catch and the fix. |
|
@tdas should this be back-ported into 1.0? |
|
@tdas nvm - I think this just doesn't exist in 1.0 :) |
…call The line break inadvertently means this was interpreted as a call to the no-arg constructor. This doesn't exist in older Netty even. (Also fixed a val name typo.) Author: Sean Owen <[email protected]> Closes apache#1466 from srowen/SPARK-1478.2 and squashes the following commits: 59c3501 [Sean Owen] Line break caused Scala to interpret NioServerSocketChannelFactory constructor as the no-arg version, which is not even present in some versions of Netty
… to 3.4) (apache#1808) * rdar://111235765 ALTER TABLE ... WRITE command (apache#1231) (apache#1466) This PR cherry-picks the command to set write distribution and ordering in a table. These changes are needed to allow customers to control the required distribution and ordering in Iceberg. It adds a new command that will be only supported by the Iceberg data source. This PR comes with tests. * rdar://84102488 Support ordering and distribution during table creation (apache#1485) This PR cherry-picks the ordering and distribution during table creation to 3.2. The same syntax is supported in 3.0 and 3.1. These changes are needed to define a sort key and distribution in Iceberg tables. Yes but the changes won't affect anyone except Iceberg users. This PR comes with tests. Co-authored-by: Russell Spitzer <[email protected]> Co-authored-by: Anton Okolnychyi <[email protected]>
The line break inadvertently means this was interpreted as a call to the no-arg constructor. This doesn't exist in older Netty even. (Also fixed a val name typo.)