[SPARK-19333][SPARKR] Add Apache License headers to R files #16709
Conversation
|
Test build #72015 has finished for PR 16709 at commit
|
| @@ -10,6 +10,23 @@ vignette: > | |||
| \usepackage[utf8]{inputenc} | |||
| --- | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
I don't think we need license headers in doc files -- I don't think others have this.
You could add one to DESCRIPTION for good measure but it's really conf.
There was a problem hiding this comment.
I have worked with a few Apache projects that do this in doc though.
I understand we don't. I'm fine either way but since the JIRA is opened, there really isn't any file without license except for DESCRIPTION (doesn't support comment, already has a license tag) and NAMESPACE (which is really a build file, and very often tool generated).
There was a problem hiding this comment.
FWIW the ASF policy statement talks about source files only: http://www.apache.org/legal/release-policy.html#license-headers
Is this source for docs? maybe so. I think it's fine as-is then.
There was a problem hiding this comment.
right, this file actually contains source code that gets run to generate output that gets included in generated doc (as a html file) in the Apache source release.
## What changes were proposed in this pull request? add header ## How was this patch tested? Manual run to check vignettes html is created properly Author: Felix Cheung <[email protected]> Closes #16709 from felixcheung/rfilelicense. (cherry picked from commit 385d738) Signed-off-by: Felix Cheung <[email protected]>
## What changes were proposed in this pull request? add header ## How was this patch tested? Manual run to check vignettes html is created properly Author: Felix Cheung <[email protected]> Closes #16709 from felixcheung/rfilelicense. (cherry picked from commit 385d738) Signed-off-by: Felix Cheung <[email protected]>
|
merged to master, branch-2.1, branch-2.0 |
## What changes were proposed in this pull request? add header ## How was this patch tested? Manual run to check vignettes html is created properly Author: Felix Cheung <[email protected]> Closes apache#16709 from felixcheung/rfilelicense.
What changes were proposed in this pull request?
add header
How was this patch tested?
Manual run to check vignettes html is created properly