[SPARK-20124][SQL] Join reorder should keep the same order of final project attributes #17453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cloud-fan please review |
hvanhovell
reviewed
Mar 28, 2017
| @@ -127,7 +127,8 @@ abstract class PlanTest extends SparkFunSuite with PredicateHelper { | |||
| (sameJoinPlan(j1.left, j2.left) && sameJoinPlan(j1.right, j2.right)) || | |||
| (sameJoinPlan(j1.left, j2.right) && sameJoinPlan(j1.right, j2.left)) | |||
| case _ if plan1.children.nonEmpty && plan2.children.nonEmpty => | |||
| (plan1.children, plan2.children).zipped.forall { case (c1, c2) => sameJoinPlan(c1, c2) } | |||
| plan1 == plan2 && | |||
There was a problem hiding this comment.
Why should they be equal? This implies that the entire subree is the same as well right?
There was a problem hiding this comment.
Yes you are right. There's some confusion here.
|
Test build #75305 has finished for PR 17453 at commit
|
|
Test build #75310 has finished for PR 17453 at commit
|
|
LGTM, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Join reorder algorithm should keep exactly the same order of output attributes in the top project.
For example, if user want to select a, b, c, after reordering, we should output a, b, c in the same order as specified by user, instead of b, a, c or other orders.
How was this patch tested?
A new test case is added in
JoinReorderSuite.