-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-20535][SPARKR] R wrappers for explode_outer and posexplode_outer #17809
Conversation
Test build #76305 has finished for PR 17809 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
R/pkg/R/functions.R
Outdated
#' posexplode_outer | ||
#' | ||
#' Creates a new row for each element with position in the given array or map column. | ||
#' Unlike \code{posexplode}, if the array/map is null or empty then the row (null, null) is produced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to put null in \code as L3810
typically I'd say NULL
instead but this is actually null on JVM side so I think it's ok as it is/
Test build #76317 has started for PR 17809 at commit |
Test build #76319 has finished for PR 17809 at commit
|
Jenkins retest this please. |
Test build #76327 has finished for PR 17809 at commit
|
merged to master, thanks! |
Thanks @felixcheung |
What changes were proposed in this pull request?
Ad R wrappers for
o.a.s.sql.functions.explode_outer
o.a.s.sql.functions.posexplode_outer
How was this patch tested?
Additional unit tests, manual testing.