Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-20535][SPARKR] R wrappers for explode_outer and posexplode_outer #17809

Closed
wants to merge 2 commits into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Apr 29, 2017

What changes were proposed in this pull request?

Ad R wrappers for

  • o.a.s.sql.functions.explode_outer
  • o.a.s.sql.functions.posexplode_outer

How was this patch tested?

Additional unit tests, manual testing.

@SparkQA
Copy link

SparkQA commented Apr 29, 2017

Test build #76305 has finished for PR 17809 at commit 891c8e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

#' posexplode_outer
#'
#' Creates a new row for each element with position in the given array or map column.
#' Unlike \code{posexplode}, if the array/map is null or empty then the row (null, null) is produced.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to put null in \code as L3810
typically I'd say NULL instead but this is actually null on JVM side so I think it's ok as it is/

@SparkQA
Copy link

SparkQA commented Apr 30, 2017

Test build #76317 has started for PR 17809 at commit 1d21bce.

@SparkQA
Copy link

SparkQA commented Apr 30, 2017

Test build #76319 has finished for PR 17809 at commit 1d21bce.

  • This patch fails SparkR unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zero323
Copy link
Member Author

zero323 commented Apr 30, 2017

Jenkins retest this please.

@SparkQA
Copy link

SparkQA commented Apr 30, 2017

Test build #76327 has finished for PR 17809 at commit 1d21bce.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

merged to master, thanks!

@asfgit asfgit closed this in ae3df4e Apr 30, 2017
@zero323
Copy link
Member Author

zero323 commented Apr 30, 2017

Thanks @felixcheung

@zero323 zero323 deleted the SPARK-20535 branch April 30, 2017 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants