Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SQL] Tighten the visibility of various SQLConf methods and renamed setter/getters #1794

Closed
wants to merge 2 commits into from
Closed

[SQL] Tighten the visibility of various SQLConf methods and renamed setter/getters #1794

wants to merge 2 commits into from

Conversation

rxin
Copy link
Contributor

@rxin rxin commented Aug 6, 2014

No description provided.

@rxin rxin changed the title Tighten the visibility of various SQLConf methods and renamed setter/getters [SQL] Tighten the visibility of various SQLConf methods and renamed setter/getters Aug 6, 2014
@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1794. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17972/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1794:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17972/consoleFull

@rxin
Copy link
Contributor Author

rxin commented Aug 6, 2014

@concretevitamin

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1794. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17983/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1794:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17983/consoleFull

@marmbrus
Copy link
Contributor

marmbrus commented Aug 6, 2014

test this please

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1794. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17986/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1794:
- This patch FAILED unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17986/consoleFull

@marmbrus
Copy link
Contributor

marmbrus commented Aug 6, 2014

test this please

concretevitamin
concretevitamin reviewed Aug 6, 2014
View reviewed changes
sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala
@@ -17,17 +17,17 @@

package org.apache.spark.sql

import scala.collection.immutable
import scala.collection.JavaConversions._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: under the java import & switch order of these two

@marmbrus
Copy link
Contributor

marmbrus commented Aug 6, 2014

Ran tests locally. I'm going to merge.

@concretevitamin
Copy link
Contributor

Hey @rxin -- I think this is good to go.

@asfgit asfgit closed this in b70bae4 Aug 6, 2014
asfgit pushed a commit that referenced this pull request Aug 6, 2014
@rxin @marmbrus
[SQL] Tighten the visibility of various SQLConf methods and renamed s…
4f0b4f4 
…etter/getters

Author: Reynold Xin <[email protected]>

Closes #1794 from rxin/sql-conf and squashes the following commits:

3ac11ef [Reynold Xin] getAllConfs return an immutable Map instead of an Array.
4b19d6c [Reynold Xin] Tighten the visibility of various SQLConf methods and renamed setter/getters.

(cherry picked from commit b70bae4)
Signed-off-by: Michael Armbrust <[email protected]>
@rxin rxin deleted the sql-conf branch August 13, 2014 08:00
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
@rxin @conviva-zz
[SQL] Tighten the visibility of various SQLConf methods and renamed s…
e8e2eb9 
…etter/getters

Author: Reynold Xin <[email protected]>

Closes apache#1794 from rxin/sql-conf and squashes the following commits:

3ac11ef [Reynold Xin] getAllConfs return an immutable Map instead of an Array.
4b19d6c [Reynold Xin] Tighten the visibility of various SQLConf methods and renamed setter/getters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rxin @SparkQA @marmbrus @concretevitamin