Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-2866][SQL] Support attributes in ORDER BY that aren't in SELECT #1795

Closed
wants to merge 4 commits into from

Conversation

marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Aug 6, 2014

Minor refactoring to allow resolution either using a nodes input or output.

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1795. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17967/consoleFull

*/
object ResolveSortReferences extends Rule[LogicalPlan] {
def apply(plan: LogicalPlan): LogicalPlan = plan transformUp {
case s@Sort(ordering, p@Project(projectList, child)) if !s.resolved && p.resolved =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces before and after @

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA tests have started for PR 1795. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17979/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1795:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17967/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 6, 2014

QA results for PR 1795:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds no public classes

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17979/consoleFull

@marmbrus
Copy link
Contributor Author

marmbrus commented Aug 6, 2014

Thanks for the comments. I've merged this into master and branch 1.1

asfgit pushed a commit that referenced this pull request Aug 6, 2014
Minor refactoring to allow resolution either using a nodes input or output.

Author: Michael Armbrust <[email protected]>

Closes #1795 from marmbrus/ordering and squashes the following commits:

237f580 [Michael Armbrust] style
74d833b [Michael Armbrust] newline
705d963 [Michael Armbrust] Add a rule for resolving ORDER BY expressions that reference attributes not present in the SELECT clause.
82cabda [Michael Armbrust] Generalize attribute resolution.

(cherry picked from commit 1d70c4f)
Signed-off-by: Michael Armbrust <[email protected]>
@asfgit asfgit closed this in 1d70c4f Aug 6, 2014
@marmbrus marmbrus deleted the ordering branch August 27, 2014 20:47
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Minor refactoring to allow resolution either using a nodes input or output.

Author: Michael Armbrust <[email protected]>

Closes apache#1795 from marmbrus/ordering and squashes the following commits:

237f580 [Michael Armbrust] style
74d833b [Michael Armbrust] newline
705d963 [Michael Armbrust] Add a rule for resolving ORDER BY expressions that reference attributes not present in the SELECT clause.
82cabda [Michael Armbrust] Generalize attribute resolution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants