-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-2866][SQL] Support attributes in ORDER BY that aren't in SELECT #1795
Conversation
…es not present in the SELECT clause.
QA tests have started for PR 1795. This patch merges cleanly. |
*/ | ||
object ResolveSortReferences extends Rule[LogicalPlan] { | ||
def apply(plan: LogicalPlan): LogicalPlan = plan transformUp { | ||
case s@Sort(ordering, p@Project(projectList, child)) if !s.resolved && p.resolved => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces before and after @
QA tests have started for PR 1795. This patch merges cleanly. |
QA results for PR 1795: |
QA results for PR 1795: |
Thanks for the comments. I've merged this into master and branch 1.1 |
Minor refactoring to allow resolution either using a nodes input or output. Author: Michael Armbrust <[email protected]> Closes #1795 from marmbrus/ordering and squashes the following commits: 237f580 [Michael Armbrust] style 74d833b [Michael Armbrust] newline 705d963 [Michael Armbrust] Add a rule for resolving ORDER BY expressions that reference attributes not present in the SELECT clause. 82cabda [Michael Armbrust] Generalize attribute resolution. (cherry picked from commit 1d70c4f) Signed-off-by: Michael Armbrust <[email protected]>
Minor refactoring to allow resolution either using a nodes input or output. Author: Michael Armbrust <[email protected]> Closes apache#1795 from marmbrus/ordering and squashes the following commits: 237f580 [Michael Armbrust] style 74d833b [Michael Armbrust] newline 705d963 [Michael Armbrust] Add a rule for resolving ORDER BY expressions that reference attributes not present in the SELECT clause. 82cabda [Michael Armbrust] Generalize attribute resolution.
Minor refactoring to allow resolution either using a nodes input or output.