Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spark QA] [WIP] Include commit hash in Spark QA messages #1811

Closed
wants to merge 30 commits into from
Closed

[Spark QA] [WIP] Include commit hash in Spark QA messages #1811

Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
75ad552
make check output style consistent
nchammas Aug 2, 2014
61c07b9
[SPARK-2627] add Python linter
nchammas Aug 2, 2014
12440fa
[SPARK-2627] add Scala linter
nchammas Aug 2, 2014
0541ebb
[SPARK-2627] call Python linter from run-tests
nchammas Aug 2, 2014
723ed39
always delete the report file
nchammas Aug 2, 2014
beaa9ac
[SPARK-2627] fail check on non-zero status
nchammas Aug 3, 2014
a31ccc4
[SPARK-2627] miscellaneous PEP 8 fixes
nchammas Aug 3, 2014
9a66cb0
resolving merge conflicts
nchammas Aug 3, 2014
9c01d4c
Merge pull request #1 from apache/master
nchammas Aug 3, 2014
fe57ed0
removing merge conflict backups
nchammas Aug 3, 2014
6f4900b
[SPARK-2627] more misc PEP 8 fixes
nchammas Aug 3, 2014
21da538
[SPARK-2627] it's PEP 8, not PEP8
nchammas Aug 3, 2014
a1ce7ae
[SPARK-2627] space out test report sections
nchammas Aug 3, 2014
dffb5dd
[SPARK-2627] download pep8 at runtime
nchammas Aug 3, 2014
d0a83b9
[SPARK-2627] check that pep8 downloaded fine
nchammas Aug 3, 2014
aa5b4b5
[SPARK-2627] follow Spark bash style for if blocks
nchammas Aug 4, 2014
9da347f
Merge pull request #2 from apache/master
nchammas Aug 4, 2014
bfb9f9f
[SPARK-2627] keep up with the PEP 8 fixes
nchammas Aug 4, 2014
b09fae2
don't wrap comments unnecessarily
nchammas Aug 4, 2014
44e3e56
[SPARK-2627] use tox.ini to exclude files
nchammas Aug 4, 2014
91b7584
[SPARK-2627] undo unnecessary line breaks
nchammas Aug 4, 2014
7b4750e
merge upstream changes
nchammas Aug 4, 2014
6db9a44
Merge pull request #3 from apache/master
nchammas Aug 4, 2014
bf30942
[SPARK-2627] PEP8: comment spacing
nchammas Aug 4, 2014
0e0245f
[SPARK-2627] undo erroneous whitespace fixes
nchammas Aug 5, 2014
1db5314
Merge pull request #4 from apache/master
nchammas Aug 5, 2014
983d963
Merge pull request #5 from apache/master
nchammas Aug 6, 2014
274b238
[SPARK-2627] [PySpark] minor indentation changes
nchammas Aug 6, 2014
b214c65
[Experimental] Include commit hash in QA message
nchammas Aug 6, 2014
8bef87d
Merge pull request #6 from apache/master
nchammas Aug 6, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions dev/run-tests-jenkins
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,15 @@ function post_message {
$COMMENTS_URL | head -n 8
}

start_message="QA tests have started for PR $ghprbPullId."
commit_url="https://github.com/apache/spark/commit/${ghprbActualCommit}"
short_commit_hash=${ghprbActualCommit:0:7}

start_message="\
QA tests have started for PR $ghprbPullId at commit hash \
[\`${short_commit_hash}\`](${commit_url}).

By the way, sha1 is \`${sha1}\`.
"
if [ "$sha1" == "$ghprbActualCommit" ]; then
start_message="$start_message This patch DID NOT merge cleanly! "
else
Expand All @@ -48,7 +56,7 @@ start_message="$start_message${BUILD_URL}consoleFull"

post_message "$start_message"

./dev/run-tests
: ./dev/run-tests # temporary; I'll undo this obviously
test_result="$?"

result_message="QA results for PR $ghprbPullId:<br>"
Expand Down