[MINOR][SQL] Fix wrong comments on org.apache.spark.sql.parquet.row.attributes #20346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @viirya |
|
Thank you for review and approval, @HyukjinKwon ! |
|
This is an old code comment we should remove it before. Thanks for fixing
it. LGTM
…On Jan 22, 2018 11:20 AM, "Dongjoon Hyun" ***@***.***> wrote:
cc @viirya <https://github.com/viirya>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20346 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEM99hcsTAQVh-D0z8DrdQyIecCn4NEks5tM_CIgaJpZM4RmFEa>
.
|
|
Thank you for review and confirming, @viirya ! |
|
Test build #86453 has finished for PR 20346 at commit
|
|
Merged to master and branch-2.3. |
asfgit
pushed a commit
that referenced
this pull request
Jan 22, 2018
…ttributes ## What changes were proposed in this pull request? This PR fixes the wrong comment on `org.apache.spark.sql.parquet.row.attributes` which is useful for UDTs like Vector/Matrix. Please see [SPARK-22320](https://issues.apache.org/jira/browse/SPARK-22320) for the usage. Originally, [SPARK-19411](bf49368#diff-ee26d4c4be21e92e92a02e9f16dbc285L314) left this behind during removing optional column metadatas. In the same PR, the same comment was removed at line 310-311. ## How was this patch tested? N/A (This is about comments). Author: Dongjoon Hyun <[email protected]> Closes #20346 from dongjoon-hyun/minor_comment_parquet. (cherry picked from commit 8142a3b) Signed-off-by: hyukjinkwon <[email protected]>
|
Thank you, @HyukjinKwon and @viirya ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the wrong comment on
org.apache.spark.sql.parquet.row.attributeswhich is useful for UDTs like Vector/Matrix. Please see SPARK-22320 for the usage.
Originally, SPARK-19411 left this behind during removing optional column metadatas. In the same PR, the same comment was removed at line 310-311.
How was this patch tested?
N/A (This is about comments).