Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-23387][SQL][PYTHON][TEST][BRANCH-2.3] Backport assertPandasEqual to branch-2.3. #20577

Closed

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Feb 11, 2018

What changes were proposed in this pull request?

When backporting a pr with tests using assertPandasEqual from master to branch-2.3, the tests fail because assertPandasEqual doesn't exist in branch-2.3.
We should backport assertPandasEqual to branch-2.3 to avoid the failures.

How was this patch tested?

Modified tests.

@ueshin
Copy link
Member Author

ueshin commented Feb 11, 2018

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Feb 11, 2018

Test build #87311 has finished for PR 20577 at commit 2c422ef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to branch-2.3.

Thanks @ueshin!

asfgit pushed a commit that referenced this pull request Feb 11, 2018
…al to branch-2.3.

## What changes were proposed in this pull request?

When backporting a pr with tests using `assertPandasEqual` from master to branch-2.3, the tests fail because `assertPandasEqual` doesn't exist in branch-2.3.
We should backport `assertPandasEqual` to branch-2.3 to avoid the failures.

## How was this patch tested?

Modified tests.

Author: Takuya UESHIN <[email protected]>

Closes #20577 from ueshin/issues/SPARK-23387/branch-2.3.
@ueshin
Copy link
Member Author

ueshin commented Feb 11, 2018

Thanks!

@ueshin ueshin closed this Feb 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants