[SPARK-23675][WEB-UI]Title add spark logo, use spark logo image #20818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ajbozarth @srowen |
srowen
approved these changes
Mar 19, 2018
|
Test build #4140 has finished for PR 20818 at commit
|
|
Test build #4141 has finished for PR 20818 at commit
|
jiangxb1987
reviewed
Mar 20, 2018
| @@ -224,6 +224,7 @@ private[spark] object UIUtils extends Logging { | |||
| {commonHeaderNodes} | |||
| {if (showVisualization) vizHeaderNodes else Seq.empty} | |||
| {if (useDataTables) dataTablesHeaderNodes else Seq.empty} | |||
| <link rel="shortcut icon" href="/static/spark-logo-77x50px-hd.png"></link> | |||
There was a problem hiding this comment.
Seems it should be prependBaseUri("/static/spark-logo-77x50px-hd.png")
jiangxb1987
reviewed
Mar 20, 2018
| @@ -265,6 +266,7 @@ private[spark] object UIUtils extends Logging { | |||
| <head> | |||
| {commonHeaderNodes} | |||
| {if (useDataTables) dataTablesHeaderNodes else Seq.empty} | |||
| <link rel="shortcut icon" href="/static/spark-logo-77x50px-hd.png"></link> | |||
There was a problem hiding this comment.
@guoxiaolongzte don't you need to change this too?
|
Ping @guoxiaolongzte |
srowen
approved these changes
Mar 23, 2018
|
You made these |
|
Test build #4144 has finished for PR 20818 at commit
|
|
Merged to master |
mshtelma
pushed a commit
to mshtelma/spark
that referenced
this pull request
Apr 5, 2018
## What changes were proposed in this pull request? Title add spark logo, use spark logo image. reference other big data system ui, so i think spark should add it. spark fix before:  spark fix after:  reference kafka ui:  reference storm ui:  reference yarn ui:  reference nifi ui:  reference flink ui:  ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <[email protected]> Closes apache#20818 from guoxiaolongzte/SPARK-23675.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Title add spark logo, use spark logo image. reference other big data system ui, so i think spark should add it.
spark fix before:
spark fix after:
reference kafka ui:
reference storm ui:
reference yarn ui:
reference nifi ui:
reference flink ui:
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.