Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MINOR][DOC] Fix a few markdown typos #20897

Closed
wants to merge 2 commits into from
Closed

[MINOR][DOC] Fix a few markdown typos #20897

wants to merge 2 commits into from

Conversation

chucheng92
Copy link
Member

What changes were proposed in this pull request?

Easy fix in the markdown.

How was this patch tested?

jekyII build test manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

@chucheng92 chucheng92 mentioned this pull request Mar 24, 2018
Closed
@felixcheung
Copy link
Member

ok to test

@SparkQA
Copy link

SparkQA commented Mar 24, 2018

Test build #88557 has finished for PR 20897 at commit 937bbef.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

jenkins, retest this please

@SparkQA
Copy link

SparkQA commented Mar 24, 2018

Test build #88558 has finished for PR 20897 at commit 937bbef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon
HyukjinKwon reviewed Mar 25, 2018
View reviewed changes
docs/mllib-feature-extraction.md
@@ -278,8 +278,8 @@ for details on the API.
multiplication. In other words, it scales each column of the dataset by a scalar multiplier. This
represents the [Hadamard product](https://en.wikipedia.org/wiki/Hadamard_product_%28matrices%29)
between the input vector, `v` and transforming vector, `scalingVec`, to yield a result vector.
Qu8T948*1#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkbradley, would you mind if I ask this was mistakenly written for sure?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon If the original author did not reply, you can look at my latest reply and confirm this confused character sequence.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

he is an active commiter / pmc. let's wait for few more days before we go ahead.

@chucheng92
Copy link
Member Author

chucheng92 commented Mar 25, 2018 •
edited
Loading

@HyukjinKwon

The description of ElementwiseProduct is obvious, and i think "Qu8T948*1#" is a mistake, if not, "Qu8T948*1#" is a input vector and 1 is scaling vector, and this is not a good example to express vector, even so, there is markdown syntax error. By the way, there is no example context here, such as "e.g."，"for example" or something else.

And i have queried the history and found another evidence. Before spark v1.6.0, this file do not have "Qu8T948*1#". So this maybe a mistaken and ambiguous character in one commit at v1.6.0 and this mistake not be found or fixed across v1.6.0 to now.

Links And Whether it appears
... no
https://github.com/apache/spark/blob/v1.4.1/docs/mllib-feature-extraction.md no
https://github.com/apache/spark/blob/v1.5.0/docs/mllib-feature-extraction.md no
https://github.com/apache/spark/blob/v1.5.2/docs/mllib-feature-extraction.md no
https://github.com/apache/spark/blob/v1.6.0/docs/mllib-feature-extraction.md yes
... yes (1.6.0 ~ 2.3.0 yes)
https://github.com/apache/spark/blob/v2.3.0/docs/mllib-feature-extraction.md yes

Thanks, and hope to confirm it.

@SparkQA
Copy link

SparkQA commented Mar 28, 2018

Test build #88650 has finished for PR 20897 at commit fb17088.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 28, 2018

Test build #88652 has finished for PR 20897 at commit 937bbef.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@chucheng92
Copy link
Member Author

chucheng92 commented Apr 2, 2018 •
edited
Loading

see http://spark.apache.org/docs/latest/ml-features.html#elementwiseproduct about "Qu8T948*1#" this confused char sequence.

chucheng92
chucheng92 commented Apr 2, 2018
View reviewed changes
docs/mllib-pmml-model-export.md
@@ -7,15 +7,15 @@ displayTitle: PMML model export - RDD-based API
* Table of contents
{:toc}

## `spark.mllib` supported models
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backquotes in mds cause display problems (see http://spark.apache.org/docs/latest/mllib-pmml-model-export.html)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@SparkQA
Copy link

SparkQA commented Apr 2, 2018

Test build #88802 has finished for PR 20897 at commit ac52bb8.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 2, 2018

Test build #88803 has finished for PR 20897 at commit d426106.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 2, 2018

Test build #88804 has finished for PR 20897 at commit 643e607.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

@felixcheung, does this look good to you too?

asfgit pushed a commit that referenced this pull request Apr 3, 2018
@HyukjinKwon
[MINOR][DOC] Fix a few markdown typos
ce15651 
## What changes were proposed in this pull request?

Easy fix in the markdown.

## How was this patch tested?

jekyII build test manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: lemonjing <[email protected]>

Closes #20897 from Lemonjing/master.

(cherry picked from commit 8020f66)
Signed-off-by: hyukjinkwon <[email protected]>
@HyukjinKwon
Copy link
Member

Merged to master and branch-2.3.

@asfgit asfgit closed this in 8020f66 Apr 3, 2018
robert3005 pushed a commit to palantir/spark that referenced this pull request Apr 4, 2018
[MINOR][DOC] Fix a few markdown typos
33b5849 
## What changes were proposed in this pull request?

Easy fix in the markdown.

## How was this patch tested?

jekyII build test manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: lemonjing <[email protected]>

Closes apache#20897 from Lemonjing/master.
mshtelma pushed a commit to mshtelma/spark that referenced this pull request Apr 5, 2018
[MINOR][DOC] Fix a few markdown typos
36a1607 
## What changes were proposed in this pull request?

Easy fix in the markdown.

## How was this patch tested?

jekyII build test manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: lemonjing <[email protected]>

Closes apache#20897 from Lemonjing/master.
peter-toth pushed a commit to peter-toth/spark that referenced this pull request Oct 6, 2018
@dongjoon-hyun
[MINOR][DOC] Fix a few markdown typos
ae8ec8a 
## What changes were proposed in this pull request?

Easy fix in the markdown.

## How was this patch tested?

jekyII build test manually.

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: lemonjing <[email protected]>

Closes apache#20897 from Lemonjing/master.

(cherry picked from commit 8020f66)
Signed-off-by: hyukjinkwon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@felixcheung felixcheung felixcheung approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chucheng92 @felixcheung @SparkQA @HyukjinKwon