[SPARK-23825][K8s] Requesting memory + memory overhead for pod memory #20943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… drivers and executors
dvogelbacher
changed the title
dvogelbacher
changed the title
|
ok to test |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Jenkins, ok to test |
|
Test build #88738 has finished for PR 20943 at commit
|
|
@felixcheung can you review this? |
felixcheung
reviewed
Apr 1, 2018
There was a problem hiding this comment.
I think this is a reasonable point.
@foxish @mccheah @erikerlandson what do you think?
foxish
reviewed
Apr 2, 2018
| @@ -91,7 +91,7 @@ class BasicDriverConfigurationStepSuite extends SparkFunSuite { | |||
| val resourceRequirements = preparedDriverSpec.driverContainer.getResources | |||
| val requests = resourceRequirements.getRequests.asScala | |||
| assert(requests("cpu").getAmount === "2") | |||
| assert(requests("memory").getAmount === "256Mi") | |||
| assert(requests("memory").getAmount === "456Mi") | |||
There was a problem hiding this comment.
I'm wondering - shouldn't this be 256M + 384M?
The documentation says - executorMemory * 0.10, with minimum of 384.
There was a problem hiding this comment.
nvm - @liyinan926 just pointed out that it's being set explicitly above which I totally missed.
foxish
approved these changes
Apr 2, 2018
| @@ -91,7 +91,7 @@ class BasicDriverConfigurationStepSuite extends SparkFunSuite { | |||
| val resourceRequirements = preparedDriverSpec.driverContainer.getResources | |||
| val requests = resourceRequirements.getRequests.asScala | |||
| assert(requests("cpu").getAmount === "2") | |||
| assert(requests("memory").getAmount === "256Mi") | |||
| assert(requests("memory").getAmount === "456Mi") | |||
There was a problem hiding this comment.
nvm - @liyinan926 just pointed out that it's being set explicitly above which I totally missed.
mccheah
approved these changes
Apr 2, 2018
dvogelbacher
changed the title
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 4, 2018
## What changes were proposed in this pull request? Kubernetes driver and executor pods should request `memory + memoryOverhead` as their resources instead of just `memory`, see https://issues.apache.org/jira/browse/SPARK-23825 ## How was this patch tested? Existing unit tests were adapted. Author: David Vogelbacher <[email protected]> Closes apache#20943 from dvogelbacher/spark-23825.
mshtelma
pushed a commit
to mshtelma/spark
that referenced
this pull request
Apr 5, 2018
## What changes were proposed in this pull request? Kubernetes driver and executor pods should request `memory + memoryOverhead` as their resources instead of just `memory`, see https://issues.apache.org/jira/browse/SPARK-23825 ## How was this patch tested? Existing unit tests were adapted. Author: David Vogelbacher <[email protected]> Closes apache#20943 from dvogelbacher/spark-23825.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Kubernetes driver and executor pods should request
memory + memoryOverheadas their resources instead of justmemory, see https://issues.apache.org/jira/browse/SPARK-23825How was this patch tested?
Existing unit tests were adapted.