[SPARK-23826] [TEST] TestHiveSparkSession should set default session #20969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #88852 has finished for PR 20969 at commit
|
|
lgtm |
gatorsmile
commented
Apr 4, 2018
| // The base spark session does this in getOrCreate(), here we emulate that behavior for tests. | ||
| if (SparkSession.getDefaultSession.isEmpty) { | ||
| SparkSession.setDefaultSession(this) | ||
| } |
There was a problem hiding this comment.
This is not needed after we merge #20927
|
Test build #88872 has finished for PR 20969 at commit
|
|
thanks, merging to master! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Apr 4, 2018
## What changes were proposed in this pull request? In TestHive, the base spark session does this in getOrCreate(), we emulate that behavior for tests. ## How was this patch tested? N/A Author: gatorsmile <[email protected]> Closes apache#20969 from gatorsmile/setDefault.
mshtelma
pushed a commit
to mshtelma/spark
that referenced
this pull request
Apr 5, 2018
## What changes were proposed in this pull request? In TestHive, the base spark session does this in getOrCreate(), we emulate that behavior for tests. ## How was this patch tested? N/A Author: gatorsmile <[email protected]> Closes apache#20969 from gatorsmile/setDefault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In TestHive, the base spark session does this in getOrCreate(), we emulate that behavior for tests.
How was this patch tested?
N/A