[SPARK-23291][R][FOLLOWUP] Update SparkR migration note for SPARK-23291 #21249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
|
cc @cloud-fan, @yanboliang, @felixcheung and @viirya. |
|
Test build #90271 has finished for PR 21249 at commit
|
viirya
reviewed
May 7, 2018
docs/sparkr.md
Outdated
|
|
||
| - The `start` parameter of `substr` method was wrongly subtracted by one, previously. In other words, the index specified by `start` parameter was considered as 0-base. This can lead to inconsistent substring results and also does not match with the behaviour with `substr` in R. It has been fixed so the `start` parameter of `substr` method is now 1-base, e.g., therefore to get the same result as `substr(df$a, 2, 5)`, it should be changed to `substr(df$a, 1, 4)`. | ||
| - In SparkR 2.3.0 and earlier, the `start` parameter of `substr` method was wrongly subtracted by one, previously. In other words, the index specified by `start` parameter was considered as 0-base. This can lead to inconsistent substring results and also does not match with the behaviour with `substr` in R. In version 2.3.1 and later, it has been fixed so the `start` parameter of `substr` method is now 1-base. As an example, `substr(lit('abcdef'), 2, 4))` would result to `abc` in SparkR 2.3.0, and the result would be `bcd` in SparkR 2.3.1. |
There was a problem hiding this comment.
nit: ...in SparkR 2.3.0 and earlier, and the result would be `bcd` in SparkR 2.3.1 and later.
There was a problem hiding this comment.
I think it's fine since it's an example ...
|
Test build #90309 has finished for PR 21249 at commit
|
|
LGTM |
|
Test build #90326 has finished for PR 21249 at commit
|
asfgit
pushed a commit
that referenced
this pull request
May 7, 2018
…ng position by 1 when calling Scala API ## What changes were proposed in this pull request? This PR backports 24b5c69 and #21249 There's no conflict but I opened this just to run the test and for sure. See the discussion in https://issues.apache.org/jira/browse/SPARK-23291 ## How was this patch tested? Jenkins tests. Author: hyukjinkwon <[email protected]> Author: Liang-Chi Hsieh <[email protected]> Closes #21250 from HyukjinKwon/SPARK-23291-backport.
yanboliang
approved these changes
May 7, 2018
|
Merged into master, thanks. |
|
Thanks, @cloud-fan, @yanboliang, @felixcheung and @viirya. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the migration note for SPARK-23291 since it's going to backport to 2.3.1. See the discussion in https://issues.apache.org/jira/browse/SPARK-23291
How was this patch tested?
N/A