[SPARK-24439][ML][PYTHON]Add distanceMeasure to BisectingKMeans in PySpark #21557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #91788 has finished for PR 21557 at commit
|
BryanCutler
requested changes
Jun 28, 2018
There was a problem hiding this comment.
Thanks @huaxingao , looks pretty good! I think we just needs to overload the set/get methods in BisectingKMeans and add the since decorator
| """ | ||
| setParams(self, featuresCol="features", predictionCol="prediction", maxIter=20, \ | ||
| seed=None, k=4, minDivisibleClusterSize=1.0) | ||
| seed=None, k=4, minDivisibleClusterSize=1.0, distanceMeasure="euclidean") | ||
| Sets params for BisectingKMeans. |
There was a problem hiding this comment.
I know we already have setDistanceMeasure and getDistanceMeasure methods from the shared param, but can you also add them here so we can use the since decorator? (same as KMeans)
There was a problem hiding this comment.
@BryanCutler Thank you very much for your review. I will make change.
|
Test build #92404 has finished for PR 21557 at commit
|
|
merged to master, thanks @huaxingao ! |
|
Thank you very much for your help! @BryanCutler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add distanceMeasure to BisectingKMeans in Python.
How was this patch tested?
added doctest and also manually tested it.