-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24571][SQL] Support Char literals #21578
Conversation
Test build #91961 has finished for PR 21578 at commit
|
jenkins, retest this, please |
Test build #91974 has finished for PR 21578 at commit
|
@rxin Please, review the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@MaxGekk Could you resolve the conflict and then I will merge it? |
Test build #92099 has finished for PR 21578 at commit
|
Test build #92100 has finished for PR 21578 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Merged to master. |
What changes were proposed in this pull request?
In the PR, I propose to automatically convert a
Literal
withChar
type to aLiteral
ofString
type. Currently, the following code:fails with the exception:
The PR fixes this issue by converting
char
tostring
of length1
. I believe it makes sense to does not differentiatechar
andstring(1)
in a unified, multi-language data platform like Spark which supports languages like Python/R.