[SPARK-24613][SQL] Cache with UDF could not be matched with subsequent dependent caches #21602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #92149 has finished for PR 21602 at commit
|
cloud-fan
reviewed
Jun 21, 2018
| @@ -132,4 +132,19 @@ class DatasetCacheSuite extends QueryTest with SharedSQLContext with TimeLimits | |||
| df.unpersist() | |||
| assert(df.storageLevel == StorageLevel.NONE) | |||
| } | |||
|
|
|||
| test("SPARK-24613 Cache with UDF could not be matched with subsequent dependent caches") { | |||
| val expensiveUDF = udf({x: Int => Thread.sleep(10000); x}) | |||
There was a problem hiding this comment.
can we use accumulator and make sure this UDF only run 10 times? sleeping 10 seconds is not good in a unit test
There was a problem hiding this comment.
Accumulators probably wouldn't work. I'll do verify plan though.
|
Test build #92158 has finished for PR 21602 at commit
|
|
retest this please |
|
Test build #92174 has finished for PR 21602 at commit
|
|
Thanks! Merged to master. |
|
This is also a regression. Backported to 2.3 branch too. |
asfgit
pushed a commit
that referenced
this pull request
Jun 27, 2018
…t dependent caches Wrap the logical plan with a `AnalysisBarrier` for execution plan compilation in CacheManager, in order to avoid the plan being analyzed again. Add one test in `DatasetCacheSuite` Author: Maryann Xue <[email protected]> Closes #21602 from maryannxue/cache-mismatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Wrap the logical plan with a
AnalysisBarrierfor execution plan compilation in CacheManager, in order to avoid the plan being analyzed again.How was this patch tested?
Add one test in
DatasetCacheSuite