-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-24715][Build] Override jline version as 2.14.3 in SBT #21692
Conversation
Nice! Mind if I ask to show the diff between |
Hmm, it seems hard to compare the diff between |
If we don't override this, which jline version does |
I've seen |
Test build #92521 has finished for PR 21692 at commit
|
Thanks, I feel it'd be better to put concrete version numbers in the description. |
@maropu Thanks. Version number is in the description now. |
Merged to master. |
@viirya thanks for this PR. I thought SBT always uses pom for dependencies, and I wonder why there is a discrepancy so we need to manually override it? |
I haven't looked into this particular issue thoroughly, but, I'm aware that SBT and Maven don't actually resolve dependencies in quite the same way. I think the resolve conflicts with different rules -- most recent wins vs 'nearest' wins. Could be it. |
Thank you all! |
Thanks @srowen for explanation. As I can tell, |
What changes were proposed in this pull request?
During SPARK-24418 (Upgrade Scala to 2.11.12 and 2.12.6), we upgrade
jline
version together. So,mvn
works correctly. However,sbt
brings old jline library and is hittingNoSuchMethodError
inmaster
branch, see #21495 (comment). This overrides jline version in SBT to make sbt build work.How was this patch tested?
Manually test.