[SPARK-24927][BUILD][BRANCH-2.3] The scope of snappy-java cannot be "provided" #21879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liancheng
changed the title
|
Test build #93585 has finished for PR 21879 at commit
|
|
retest this please |
|
The Kafka DStream test failures seem to be flaky and irrelevant. |
|
Test build #93609 has finished for PR 21879 at commit
|
|
retest this please |
|
Test build #93640 has finished for PR 21879 at commit
|
|
retest this please |
|
LGTM, how far shall we backport this patch? |
|
LGTM |
|
@cloud-fan Didn't try to actually reproduce this issue in branches other than branch-2.3, but just by checking the POM files, this issue existed ever since at least 1.6. |
|
Seems right to me too. |
|
Let us backport it to 2.2 and 2.3. |
|
Test build #93655 has finished for PR 21879 at commit
|
|
retest this please |
|
Test build #93660 has finished for PR 21879 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2018
…provided" ## What changes were proposed in this pull request? Please see [SPARK-24927][1] for more details. [1]: https://issues.apache.org/jira/browse/SPARK-24927 ## How was this patch tested? Manually tested. Author: Cheng Lian <[email protected]> Closes #21879 from liancheng/spark-24927.
asfgit
pushed a commit
that referenced
this pull request
Jul 27, 2018
…provided" ## What changes were proposed in this pull request? Please see [SPARK-24927][1] for more details. [1]: https://issues.apache.org/jira/browse/SPARK-24927 ## How was this patch tested? Manually tested. Author: Cheng Lian <[email protected]> Closes #21879 from liancheng/spark-24927. (cherry picked from commit d5f340f) Signed-off-by: Xiao Li <[email protected]>
|
Thanks! Merged to master/2.3/2.2 |
Willymontaz
pushed a commit
to criteo-forks/spark
that referenced
this pull request
Sep 26, 2019
…provided" ## What changes were proposed in this pull request? Please see [SPARK-24927][1] for more details. [1]: https://issues.apache.org/jira/browse/SPARK-24927 ## How was this patch tested? Manually tested. Author: Cheng Lian <[email protected]> Closes apache#21879 from liancheng/spark-24927. (cherry picked from commit d5f340f) Signed-off-by: Xiao Li <[email protected]>
Willymontaz
pushed a commit
to criteo-forks/spark
that referenced
this pull request
Sep 27, 2019
…provided" ## What changes were proposed in this pull request? Please see [SPARK-24927][1] for more details. [1]: https://issues.apache.org/jira/browse/SPARK-24927 ## How was this patch tested? Manually tested. Author: Cheng Lian <[email protected]> Closes apache#21879 from liancheng/spark-24927. (cherry picked from commit d5f340f) Signed-off-by: Xiao Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Please see SPARK-24927 for more details.
How was this patch tested?
Manually tested.