Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Avoid the 'latest' link that might vary per release in functions.scala's comment #21907

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR propose to address #21318 (comment) comment.

This is rather a nit but looks we better avoid to update the link for each release since it always points the latest (it doesn't look like worth enough updating release guide on the other hand as well).

How was this patch tested?

N/A

@holdensmagicalunicorn
Copy link

@HyukjinKwon, thanks! I am a bot who has found some folks who might be able to help with the review:@gatorsmile, @rxin and @davies

@SparkQA
Copy link

SparkQA commented Jul 28, 2018

Test build #93713 has finished for PR 21907 at commit d85d9e0.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Jul 28, 2018

Test build #93717 has finished for PR 21907 at commit d85d9e0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a good idea. any other web link you want to change?

@HyukjinKwon
Copy link
Member Author

Nope .. this is rather a followup for the PR to address the comment :-). This link particularly contains some contents that frequently changed (list of functions) release by release.

@HyukjinKwon
Copy link
Member Author

Merged to master.

Thank you @felixcheung.

@asfgit asfgit closed this in 6690924 Jul 30, 2018
@HyukjinKwon HyukjinKwon deleted the minor-fix branch October 16, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants