[minor] remove dead code in ExpressionEvalHelper #21958
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan, thanks! I am a bot who has found some folks who might be able to help with the review:@ueshin, @rxin and @JoshRosen |
|
LGTM |
|
Test build #93949 has finished for PR 21958 at commit
|
|
Jenkins, retest this please. |
|
LGTM. |
|
Test build #93976 has finished for PR 21958 at commit
|
|
retest this please |
|
Test build #93987 has finished for PR 21958 at commit
|
srowen
approved these changes
Aug 2, 2018
|
Thanks, merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This addresses https://github.com/apache/spark/pull/21236/files#r207078480
both #21236 and #21838 add a InternalRow result check to ExpressionEvalHelper and becomes duplicated.
How was this patch tested?
N/A