[SPARK-3429] Don't include the empty string "" as a defaultAclUser #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA tests have started for PR 2286 at commit
|
|
QA tests have finished for PR 2286 at commit
|
| @@ -162,7 +162,7 @@ private[spark] class SecurityManager(sparkConf: SparkConf) extends Logging { | |||
|
|
|||
| // always add the current user and SPARK_USER to the viewAcls | |||
| private val defaultAclUsers = Set[String](System.getProperty("user.name", ""), | |||
| Option(System.getenv("SPARK_USER")).getOrElse("")) | |||
| Option(System.getenv("SPARK_USER")).getOrElse("")).filter(_ != "") | |||
There was a problem hiding this comment.
can you change this to be !_.isEmpty
|
Thanks for working on this, I've been meaning to fix this for a while. Could you also please file a jira and link them. The header of the pr should include jira number like [SPARK-XXXX] |
ash211
changed the title
|
QA tests have started for PR 2286 at commit
|
|
QA tests have finished for PR 2286 at commit
|
|
Looks like Jenkins failed for unrelated reasons |
|
retest this please |
|
LGTM |
|
QA tests have started for PR 2286 at commit
|
|
QA tests have finished for PR 2286 at commit
|
|
Merging this into master and 1.1, thanks. |
asfgit
pushed a commit
that referenced
this pull request
Sep 12, 2014
Changes logging from ``` 14/09/05 02:01:08 INFO SecurityManager: Changing view acls to: aash, 14/09/05 02:01:08 INFO SecurityManager: Changing modify acls to: aash, 14/09/05 02:01:08 INFO SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(aash, ); users with modify permissions: Set(aash, ) ``` to ``` 14/09/05 02:28:28 INFO SecurityManager: Changing view acls to: aash 14/09/05 02:28:28 INFO SecurityManager: Changing modify acls to: aash 14/09/05 02:28:28 INFO SecurityManager: SecurityManager: authentication disabled; ui acls disabled; users with view permissions: Set(aash); users with modify permissions: Set(aash) ``` Note that the first set of logs have a Set of size 2 containing "aash" and the empty string "" cc tgravescs Author: Andrew Ash <[email protected]> Closes #2286 from ash211/empty-default-acl and squashes the following commits: 18cc612 [Andrew Ash] Use .isEmpty instead of =="" cf973a1 [Andrew Ash] Don't include the empty string "" as a defaultAclUser (cherry picked from commit ce59725) Signed-off-by: Andrew Or <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes logging from
to
Note that the first set of logs have a Set of size 2 containing "aash" and the empty string ""
cc @tgravescs