[SPARK-26865][SQL] DataSourceV2Strategy should push normalized filters #23770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this, @cloud-fan , @gatorsmile , @hvanhovell , @gengliangwang ? |
|
good catch! LGTM. |
|
Thank you for review, @cloud-fan ! |
viirya
approved these changes
Feb 13, 2019
|
Test build #102278 has finished for PR 23770 at commit
|
|
Test build #102279 has finished for PR 23770 at commit
|
|
retest this please |
| @@ -219,6 +219,11 @@ class DataSourceStrategySuite extends PlanTest with SharedSQLContext { | |||
| IsNotNull(attrInt))), None) | |||
| } | |||
|
|
|||
| test("SPARK-26865 DataSourceV2Strategy should push normalized filters") { | |||
| val attrInt = 'cint.int | |||
| DataSourceStrategy.normalizeFilters(Seq(IsNotNull(attrInt.withName("CiNt"))), Seq(attrInt)) | |||
There was a problem hiding this comment.
Should we check the result of normalizeFilters? It seems that the test case will always pass.
There was a problem hiding this comment.
Oops. Right. Thanks!
|
Also, it would be great to have regression test cases like the one in the description of https://issues.apache.org/jira/browse/SPARK-26865 |
|
Test build #102282 has finished for PR 23770 at commit
|
HyukjinKwon
approved these changes
Feb 13, 2019
|
@gengliangwang . For the second comment, I had the test case at the first commit, but this issue is not about ORC at all, so I changed it. It looks misleading. |
|
Test build #102298 has finished for PR 23770 at commit
|
|
Retest this please. |
|
Test build #102305 has finished for PR 23770 at commit
|
|
Thank you, @cloud-fan , @viirya , @gengliangwang , @HyukjinKwon . |
jackylee-ch
pushed a commit
to jackylee-ch/spark
that referenced
this pull request
Feb 18, 2019
## What changes were proposed in this pull request? This PR aims to make `DataSourceV2Strategy` normalize filters like [FileSourceStrategy](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala#L150-L158) when it pushes them into `SupportsPushDownFilters.pushFilters`. ## How was this patch tested? Pass the Jenkins with the newly added test case. Closes apache#23770 from dongjoon-hyun/SPARK-26865. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
May 15, 2019
## What changes were proposed in this pull request? This PR aims to make `DataSourceV2Strategy` normalize filters like [FileSourceStrategy](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala#L150-L158) when it pushes them into `SupportsPushDownFilters.pushFilters`. ## How was this patch tested? Pass the Jenkins with the newly added test case. Closes apache#23770 from dongjoon-hyun/SPARK-26865. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
rahij
pushed a commit
to palantir/spark
that referenced
this pull request
Feb 27, 2020
## What changes were proposed in this pull request? This PR aims to make `DataSourceV2Strategy` normalize filters like [FileSourceStrategy](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala#L150-L158) when it pushes them into `SupportsPushDownFilters.pushFilters`. ## How was this patch tested? Pass the Jenkins with the newly added test case. Closes apache#23770 from dongjoon-hyun/SPARK-26865. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Mar 9, 2020
## What changes were proposed in this pull request? This PR aims to make `DataSourceV2Strategy` normalize filters like [FileSourceStrategy](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategy.scala#L150-L158) when it pushes them into `SupportsPushDownFilters.pushFilters`. ## How was this patch tested? Pass the Jenkins with the newly added test case. Closes apache#23770 from dongjoon-hyun/SPARK-26865. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to make
DataSourceV2Strategynormalize filters like FileSourceStrategy when it pushes them intoSupportsPushDownFilters.pushFilters.How was this patch tested?
Pass the Jenkins with the newly added test case.