[SPARK-26917][SQL] Cache lock recache by condition #23833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge in spark
|
I don't know this code well, but the change looks reasonable. The question of course is somehow whether the decision to uncache something could change between where it happens before and after. It doesn't seem so, as the intent here seems to be to evaluate what is to be uncached, release the lock, then do it. Maybe CC @cloud-fan |
|
seems file, cc @maryannxue @gatorsmile |
|
Test build #4556 has finished for PR 23833 at commit
|
|
retest this please |
1 similar comment
|
retest this please |
|
I can't see the build results. Is there a problem with the Jenkins server? |
|
(There is a problem with Jenkins ATM yes) |
|
Test build #4558 has finished for PR 23833 at commit
|
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Related to SPARK-26617 and SPARK-26548. There was a new location we found where we were still seeing the locks. We traced it to the recacheByCondition function. In this PR I have changed that function so that the writeLock is not held while the condition is being evaluated.
@cloud-fan & @gatorsmile This is a further tweak to the other cache PRs we have done (which have helped us tremendously).
How was this patch tested?
Has been tested on a live system where the blocking was causing major issues and it is working well.
CacheManager has no explicit unit test but is used in many places internally as part of the SharedState.