[SPARK-27411][SQL] DataSourceV2Strategy should not eliminate subquery #24321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francis0407
changed the title
|
cc @cloud-fan |
|
ok to test |
cloud-fan
reviewed
Apr 9, 2019
|
|
||
| test("SPARK-27411: DataSourceV2Strategy should not eliminate subquery") { | ||
| val t2 = spark.read.format(classOf[SimpleDataSourceV2].getName).load() | ||
| sql("create temporary view t1 (a int) using parquet") |
There was a problem hiding this comment.
let's wrap the test with withTempView, so that the view can be cleaned up
cloud-fan
reviewed
Apr 9, 2019
| val subqueries = df.queryExecution.executedPlan.collect { | ||
| case p => p.subqueries | ||
| }.flatten | ||
| assert(subqueries.length == 1) |
There was a problem hiding this comment.
let's also check the result. I think this is a correctness bug?
cloud-fan
approved these changes
Apr 9, 2019
|
Test build #104423 has finished for PR 24321 at commit
|
|
thanks, merging to master! |
|
Test build #104426 has finished for PR 24321 at commit
|
mccheah
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 7, 2019
In DataSourceV2Strategy, it seems we eliminate the subqueries by mistake after normalizing filters.
We have a sql with a scalar subquery:
``` scala
val plan = spark.sql("select * from t2 where t2a > (select max(t1a) from t1)")
plan.explain(true)
```
And we get the log info of DataSourceV2Strategy:
```
Pushing operators to csv:examples/src/main/resources/t2.txt
Pushed Filters:
Post-Scan Filters: isnotnull(t2a#30)
Output: t2a#30, t2b#31
```
The `Post-Scan Filters` should contain the scalar subquery, but we eliminate it by mistake.
```
== Parsed Logical Plan ==
'Project [*]
+- 'Filter ('t2a > scalar-subquery#56 [])
: +- 'Project [unresolvedalias('max('t1a), None)]
: +- 'UnresolvedRelation `t1`
+- 'UnresolvedRelation `t2`
== Analyzed Logical Plan ==
t2a: string, t2b: string
Project [t2a#30, t2b#31]
+- Filter (t2a#30 > scalar-subquery#56 [])
: +- Aggregate [max(t1a#13) AS max(t1a)#63]
: +- SubqueryAlias `t1`
: +- RelationV2[t1a#13, t1b#14] csv:examples/src/main/resources/t1.txt
+- SubqueryAlias `t2`
+- RelationV2[t2a#30, t2b#31] csv:examples/src/main/resources/t2.txt
== Optimized Logical Plan ==
Filter (isnotnull(t2a#30) && (t2a#30 > scalar-subquery#56 []))
: +- Aggregate [max(t1a#13) AS max(t1a)#63]
: +- Project [t1a#13]
: +- RelationV2[t1a#13, t1b#14] csv:examples/src/main/resources/t1.txt
+- RelationV2[t2a#30, t2b#31] csv:examples/src/main/resources/t2.txt
== Physical Plan ==
*(1) Project [t2a#30, t2b#31]
+- *(1) Filter isnotnull(t2a#30)
+- *(1) BatchScan[t2a#30, t2b#31] class org.apache.spark.sql.execution.datasources.v2.csv.CSVScan
```
ut
Closes apache#24321 from francis0407/SPARK-27411.
Authored-by: francis0407 <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In DataSourceV2Strategy, it seems we eliminate the subqueries by mistake after normalizing filters.
We have a sql with a scalar subquery:
And we get the log info of DataSourceV2Strategy:
The
Post-Scan Filtersshould contain the scalar subquery, but we eliminate it by mistake.How was this patch tested?
ut