Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-3704][SQL]ColumnValue types not match in hive row and spark row #2551

Closed
wants to merge 1 commit into from
Closed

[SPARK-3704][SQL]ColumnValue types not match in hive row and spark row #2551

wants to merge 1 commit into from

Conversation

scwf
Copy link
Contributor

@scwf scwf commented Sep 27, 2014

case ShortType, we should add short value to hive row. Int value may lead to some problems.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@marmbrus
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

QA tests have started for PR 2551 at commit 08bcc59.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 27, 2014

Tests timed out after a configured wait of 120m.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20923/

@scwf scwf mentioned this pull request Sep 30, 2014
Closed
@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have started for PR 2551 at commit 08bcc59.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 1, 2014

QA tests have finished for PR 2551 at commit 08bcc59.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • println(s"Failed to load main class $childMainClass.")

@marmbrus
Copy link
Contributor

marmbrus commented Oct 1, 2014

Thanks! I've merged this to master.

@asfgit asfgit closed this in 1b9f0d6 Oct 1, 2014
@scwf scwf deleted the fix-addColumnValue branch October 3, 2014 13:17
marmbrus pushed a commit to marmbrus/spark that referenced this pull request Nov 11, 2014
@scwf @marmbrus
[SPARK-3704][SQL] Fix ColumnValue type for Short values in thrift server
064750d 
case ```ShortType```, we should add short value to hive row. Int value may lead to some problems.

Author: scwf <[email protected]>

Closes apache#2551 from scwf/fix-addColumnValue and squashes the following commits:

08bcc59 [scwf] ColumnValue.shortValue for short type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scwf @AmplabJenkins @marmbrus @SparkQA