Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-22797][ML][PYTHON] Bucketizer support multi-column #25801

Closed
wants to merge 2 commits into from
Closed

[SPARK-22797][ML][PYTHON] Bucketizer support multi-column #25801

wants to merge 2 commits into from

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Bucketizer support multi-column in the python side

Why are the changes needed?

Bucketizer should support multi-column like the scala side.

Does this PR introduce any user-facing change?

yes, this PR add new Python API

How was this patch tested?

added testsuites

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Sep 16, 2019 •
edited
Loading

The previous pr #19892 was reverted because it triggered py test suite failure, see issue #20410 for detail.
Now, this issue was already fixed by #18982.

@zhengruifeng zhengruifeng mentioned this pull request Sep 16, 2019
Closed
@zhengruifeng
Copy link
Contributor Author

cc @srowen @mgaido91 @BryanCutler @holdenk

@mgaido91
Copy link
Contributor

LGTM

@zhengruifeng
Copy link
Contributor Author

retest this please

srowen
srowen approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests (Jenkins is offline)

@SparkQA
Copy link

SparkQA commented Sep 16, 2019

Test build #110633 has finished for PR 25801 at commit 6ec8384.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon mentioned this pull request Sep 17, 2019
Closed
@zhengruifeng
Copy link
Contributor Author

Merged to master. Thanks all for reviewing!

@zhengruifeng zhengruifeng deleted the 20542_py branch September 17, 2019 03:54
@zero323 zero323 mentioned this pull request Sep 20, 2019
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen approved these changes

Assignees
No one assigned
Labels
ML PYSPARK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhengruifeng @mgaido91 @SparkQA @srowen