-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-29258][ML][PYSPARK] parity between ml.evaluator and mllib.metrics #25940
Conversation
Test build #111411 has finished for PR 25940 at commit
|
Test build #111422 has finished for PR 25940 at commit
|
Test build #111424 has finished for PR 25940 at commit
|
case "r2" => true | ||
case "mae" => false | ||
case "var" => true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total nit, but you could write case "r2" | "var" => true
Test build #111459 has finished for PR 25940 at commit
|
Merged to master. Thanks @srowen for reviewing |
What changes were proposed in this pull request?
1, expose
BinaryClassificationMetrics.numBins
inBinaryClassificationEvaluator
2, expose
RegressionMetrics.throughOrigin
inRegressionEvaluator
3, add metric
explainedVariance
inRegressionEvaluator
Why are the changes needed?
existing function in mllib.metrics should also be exposed in ml
Does this PR introduce any user-facing change?
yes, this PR add two expert params and one metric option
How was this patch tested?
existing and added tests