Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-29258][ML][PYSPARK] parity between ml.evaluator and mllib.metrics #25940

Closed
wants to merge 5 commits into from

Conversation

zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

1, expose BinaryClassificationMetrics.numBins in BinaryClassificationEvaluator
2, expose RegressionMetrics.throughOrigin in RegressionEvaluator
3, add metric explainedVariance in RegressionEvaluator

Why are the changes needed?

existing function in mllib.metrics should also be exposed in ml

Does this PR introduce any user-facing change?

yes, this PR add two expert params and one metric option

How was this patch tested?

existing and added tests

@SparkQA
Copy link

SparkQA commented Sep 26, 2019

Test build #111411 has finished for PR 25940 at commit aaef3f7.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 26, 2019

Test build #111422 has finished for PR 25940 at commit 932a17e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Sep 26, 2019

Test build #111424 has finished for PR 25940 at commit 4b4cbc6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

case "r2" => true
case "mae" => false
case "var" => true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total nit, but you could write case "r2" | "var" => true

@SparkQA
Copy link

SparkQA commented Sep 27, 2019

Test build #111459 has finished for PR 25940 at commit 45139b5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@zhengruifeng
Copy link
Contributor Author

Merged to master. Thanks @srowen for reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants