[SPARK-29269][PYTHON][ML] Pyspark ALSModel support getters/setters #25947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #111468 has finished for PR 25947 at commit
|
viirya
reviewed
Sep 27, 2019
| @@ -131,7 +131,7 @@ private[recommendation] trait ALSModelParams extends Params with HasPredictionCo | |||
| * Common params for ALS. | |||
| */ | |||
| private[recommendation] trait ALSParams extends ALSModelParams with HasMaxIter with HasRegParam | |||
| with HasPredictionCol with HasCheckpointInterval with HasSeed { | |||
| with HasCheckpointInterval with HasSeed { | |||
There was a problem hiding this comment.
Because ALSModelParams already has HasPredictionCol?
There was a problem hiding this comment.
Yes. It seems to be redundant to me.
viirya
reviewed
Sep 27, 2019
| """ | ||
| Model fitted by ALS. | ||
|
|
||
| .. versionadded:: 1.4.0 | ||
| """ | ||
|
|
||
| @since("1.4.0") | ||
| def setUserCol(self, value): |
There was a problem hiding this comment.
These are newly added, right? So which one is more correct, since(1.4.0) or since(3.0.0)?
There was a problem hiding this comment.
Should be since(3.0.0). Thanks for catching that problem.
|
Test build #111505 has finished for PR 25947 at commit
|
|
Test build #111748 has finished for PR 25947 at commit
|
|
Test build #111758 has finished for PR 25947 at commit
|
zhengruifeng
approved these changes
Oct 8, 2019
|
retest this please |
|
Test build #111866 has finished for PR 25947 at commit
|
|
Merged to master. Thanks all! |
|
Thanks! @viirya @zhengruifeng |
Closed
47 tasks
atronchi
pushed a commit
to atronchi/spark
that referenced
this pull request
Oct 23, 2019
### What changes were proposed in this pull request? Add getters/setters in Pyspark ALSModel. ### Why are the changes needed? To keep parity between python and scala. ### Does this PR introduce any user-facing change? Yes. add the following getters/setters to ALSModel ``` get/setUserCol get/setItemCol get/setColdStartStrategy get/setPredictionCol ``` ### How was this patch tested? add doctest Closes apache#25947 from huaxingao/spark-29269. Authored-by: Huaxin Gao <[email protected]> Signed-off-by: zhengruifeng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add getters/setters in Pyspark ALSModel.
Why are the changes needed?
To keep parity between python and scala.
Does this PR introduce any user-facing change?
Yes.
add the following getters/setters to ALSModel
How was this patch tested?
add doctest