Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30378][ML][PySpark] Add getter/setter in Python FM #27044

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

add getter/setter in Python FM

Why are the changes needed?

to be consistent with other algorithms

Does this PR introduce any user-facing change?

Yes.
add getter/setter in Python FMRegressor/FMRegressionModel/FMClassifier/FMClassificationModel

How was this patch tested?

doctest

@SparkQA
Copy link

SparkQA commented Dec 30, 2019

Test build #115924 has finished for PR 27044 at commit c141f52.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class FMClassifier(JavaProbabilisticClassifier, _FactorizationMachinesParams, JavaMLWritable,
  • class FMClassificationModel(JavaProbabilisticClassificationModel, _FactorizationMachinesParams,
  • class _FactorizationMachinesParams(_JavaPredictorParams, HasMaxIter, HasStepSize, HasTol,
  • class FMRegressor(JavaPredictor, _FactorizationMachinesParams, JavaMLWritable, JavaMLReadable):
  • class FMRegressionModel(JavaPredictionModel, _FactorizationMachinesParams, JavaMLWritable,

@zhengruifeng
Copy link
Contributor

Merged to master, thanks @huaxingao

@huaxingao
Copy link
Contributor Author

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants