Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30452][ML][PySpark] Add predict and numFeatures in Python IsotonicRegressionModel #27122

Closed
wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

What changes were proposed in this pull request?

Add predict and numFeatures in Python IsotonicRegressionModel

Why are the changes needed?

IsotonicRegressionModel doesn't extend JavaPredictionModel, so it doesn't get predict and numFeatures from the super class.

Does this PR introduce any user-facing change?

Yes. Python version of

IsotonicRegressionModel.predict
IsotonicRegressionModel.numFeatures

How was this patch tested?

doctest

@SparkQA
Copy link

SparkQA commented Jan 8, 2020

Test build #116269 has finished for PR 27122 at commit 75bdbe9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 9, 2020

Merged to master

@srowen srowen closed this in c88124a Jan 9, 2020
@huaxingao
Copy link
Contributor Author

Thanks! @srowen @zhengruifeng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants