Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3899][Doc]fix wrong links in streaming doc #2749

Closed
wants to merge 2 commits into from

Conversation

scwf
Copy link
Contributor

@scwf scwf commented Oct 10, 2014

There are three [Custom Receiver Guide] links in streaming doc, the first is wrong.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@scwf scwf changed the title [Doc]fix wrong links in streaming doc [SPARK-3899][Doc]fix wrong links in streaming doc Oct 10, 2014
@JoshRosen
Copy link
Contributor

Good catch. Do you mind updating this to link to the #implementing-and-using-a-custom-actor-based-receiver anchor on the new page?

@scwf
Copy link
Contributor Author

scwf commented Oct 13, 2014

Hmm, but #implementing-and-using-a-custom-actor-based-receiver is not a valid link, sorry, did not get you, can you explain more?

@JoshRosen
Copy link
Contributor

Oh, I meant that you could have linked the page like this, so that the link jumps to the Akka-specific section: https://spark.apache.org/docs/latest/streaming-custom-receivers.html#implementing-and-using-a-custom-actor-based-receiver.

@scwf
Copy link
Contributor Author

scwf commented Oct 13, 2014

Get it, use streaming-custom-receivers.html#implementing-and-using-a-custom-actor-based-receiver here jump to the Akka-specific section:)

@scwf
Copy link
Contributor Author

scwf commented Oct 13, 2014

Updated.

@JoshRosen
Copy link
Contributor

LGTM. Thanks!

@asfgit asfgit closed this in 92e017f Oct 13, 2014
asfgit pushed a commit that referenced this pull request Oct 13, 2014
There are three  [Custom Receiver Guide] links in streaming doc, the first is wrong.

Author: w00228970 <[email protected]>
Author: wangfei <[email protected]>

Closes #2749 from scwf/streaming-doc and squashes the following commits:

0cd76b7 [wangfei] update link tojump to the Akka-specific section
45b0646 [w00228970] wrong link in streaming doc

(cherry picked from commit 92e017f)
Signed-off-by: Josh Rosen <[email protected]>
@scwf scwf deleted the streaming-doc branch October 13, 2014 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants