Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-3955] Different versions between jackson-mapper-asl and jackson-core-asl #2818

Closed
wants to merge 3 commits into from
Closed

[SPARK-3955] Different versions between jackson-mapper-asl and jackson-core-asl #2818

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6b1bd9
[SPARK-3955] Different versions between jackson-mapper-asl and jackso…
jongyoul Oct 16, 2014
ad0fc25
[SPARK-3955] Different versions between jackson-mapper-asl and jackso…
jongyoul Oct 16, 2014
e3ed001
[SPARK-3955] Different versions between jackson-mapper-asl and jackso…
jongyoul Oct 22, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@
<jets3t.version>0.7.1</jets3t.version>
<aws.java.sdk.version>1.8.3</aws.java.sdk.version>
<aws.kinesis.client.version>1.1.0</aws.kinesis.client.version>
<jackson.version>1.8.8</jackson.version>

<PermGen>64m</PermGen>
<MaxPermGen>512m</MaxPermGen>
Expand Down Expand Up @@ -750,11 +751,16 @@
</exclusion>
</exclusions>
</dependency>
<!-- Matches the version of jackson-{mapper,core}-asl pulled in by avro -->
<dependency>
<!-- Matches the version of jackson-core-asl pulled in by avro -->
<groupId>org.codehaus.jackson</groupId>
<artifactId>jackson-mapper-asl</artifactId>
<version>1.8.8</version>
<version>${jackson.version}</version>
</dependency>
<dependency>
<groupId>org.codehaus.jackson</groupId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think defining a dependency here will have any effect if we don't ever use it in our own build... right? I don't think we list jackson-core-asl anywhere in our component pom files as a dependency.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwendell Yes, that's true that that setting doesn't affect spark build, however, anyone use a jackson library in a spark framework, they always fail because of different versions between mapper and core of jackson. I don't think it's not nice and, in my opinion, there are two solutions. One is setting that pom.xml like that and another one is an exclusion of that library explicitly.

<artifactId>jackson-core-asl</artifactId>
<version>${jackson.version}</version>
</dependency>
</dependencies>
</dependencyManagement>
Expand Down Expand Up @@ -1153,7 +1159,7 @@
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>3.4.5-mapr-1406</version>
<version>3.4.5-mapr-1406</version>
</dependency>
</dependencies>
</profile>
Expand Down