-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-32357][INFRA] Add a step in GitHub Actions to show failed tests #29169
Conversation
This comment has been minimized.
This comment has been minimized.
Oh. The idea looks nice, @viirya . |
cc @gengliangwang and @HyukjinKwon |
This comment has been minimized.
This comment has been minimized.
Test build #126205 has finished for PR 29169 at commit
|
Yeah, +1 |
Let me take a quick look if there are any other good easy way to do this. If there' no, let's go for this way 👍 |
Thanks @HyukjinKwon |
Let me test out some other GitHub actions like https://github.com/check-run-reporter/action, https://github.com/ashley-taylor/junit-report-annotations-action or other ways around to see if it's feasible or not, and then come back. |
Test build #126747 has finished for PR 29169 at commit
|
@HyukjinKwon Hi, this is for a while. Do you have some more thoughts? Thanks. |
Hey, sorry for the late responses. I just had some time to try a couple of plugins and figured out one working. I made a PR and cc'ed you there. |
There is an existing plugin visually looking nice and seems working. Close this one. |
What changes were proposed in this pull request?
Currently, the readability in the logs of GitHub Actions are not really good. This proposes to add a step in GitHub Actions to show failed tests if any. This new step
"Failed tests"
will be triggered if previous step"Run tests: ${{ matrix.modules }}"
has failure.Why are the changes needed?
More easier to find failed tests in GitHub Actions.
Does this PR introduce any user-facing change?
No. This is for developer-only.
How was this patch tested?
Test on Github.