[SPARK-31999][SQL][FOLLOWUP] Adds negative test cases with typo fixes #29453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @gatorsmile I have not changed any code for the #comment, please let me know if you want to do it. |
HyukjinKwon
changed the title
|
Test build #127517 has finished for PR 29453 at commit
|
|
Test build #127542 has finished for PR 29453 at commit
|
|
Test build #127560 has finished for PR 29453 at commit
|
maropu
reviewed
Aug 19, 2020
| @@ -3035,7 +3035,10 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils { | |||
| val msg = intercept[AnalysisException] { | |||
| sql("REFRESH FUNCTION md5") | |||
| }.getMessage | |||
| assert(msg.contains("Cannot refresh builtin function")) | |||
| assert(msg.contains("Cannot refresh built-in function")) | |||
| intercept[NoSuchFunctionException] { | |||
There was a problem hiding this comment.
nit: just in case, could you check the error message, too?
maropu
reviewed
Aug 19, 2020
| sql("CREATE FUNCTION func1 AS 'test.org.apache.spark.sql.MyDoubleAvg'") | ||
| assert(!spark.sessionState.catalog.isRegisteredFunction(func)) | ||
| sql("REFRESH FUNCTION func1") | ||
| assert(spark.sessionState.catalog.isRegisteredFunction(func)) | ||
| intercept[NoSuchFunctionException] { |
|
Test build #127619 has finished for PR 29453 at commit
|
|
thanks, merging to master! |
cloud-fan
changed the title
|
BTW @ulysses-you don't forget about #28840 (comment) :) |
|
thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address the #comment.
Why are the changes needed?
Make code robust.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
ut.