[SPARK-27872][K8S][2.4] Fix executor service account inconsistency #29877
Conversation
There's no javadoc in the original PR (#24748). This is simply a backport. Any improvements can follow in a different PR. |
|
@dongjoon-hyun @erikerlandson please let me know if you have additional comments that I can address. |
|
ping: @dongjoon-hyun @erikerlandson, please review when you get a chance. |
|
Checking again for this PR: @dongjoon-hyun @erikerlandson. |
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
Show resolved
Hide resolved
|
ok to test |
We might need an admin to initiate tests again. ping @dongjoon-hyun |
|
ok to test |
|
Retest this please |
dongjoon-hyun
changed the title
|
Kubernetes integration test starting |
|
Test build #129467 has finished for PR 29877 at commit
|
|
Kubernetes integration test status success |
|
Thanks @dongjoon-hyun. |
...ce-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
Outdated
Show resolved
Hide resolved
...ce-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
Outdated
Show resolved
Hide resolved
...ce-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/spark/deploy/k8s/features/DriverKubernetesCredentialsFeatureStep.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStep.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStep.scala
Show resolved
Hide resolved
...in/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStep.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/spark/deploy/k8s/features/ExecutorKubernetesCredentialsFeatureStep.scala
Outdated
Show resolved
Hide resolved
...s/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
Outdated
Show resolved
Hide resolved
...s/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
Outdated
Show resolved
Hide resolved
...s/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
Outdated
Show resolved
Hide resolved
...s/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesExecutorBuilder.scala
Outdated
Show resolved
Hide resolved
...ation-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/BasicTestsSuite.scala
Outdated
Show resolved
Hide resolved
|
Thanks @dongjoon-hyun. I shall address the comments in upcoming commits. |
|
Kubernetes integration test starting |
|
Test build #129525 has finished for PR 29877 at commit
|
|
@dongjoon-hyun please let me know if you have additional comments. Tests seem to have passed. |
|
Got it. Thank you for updates. |
|
Kubernetes integration test status success |
|
@dongjoon-hyun could we merge this if there aren't additional comments or feedback? |
|
I'm OK to merge if @dongjoon-hyun is |
There was a problem hiding this comment.
+1, LGTM. Sorry for the delay, @nssalian and @erikerlandson .
Merged to branch-2.4.
### What changes were proposed in this pull request? Similar patch to #24748 but applied to the branch-2.4. Backporting the fix to releases 2.4.x. Closes #29877 from nssalian/SPARK-27872. Authored-by: nssalian <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
What changes were proposed in this pull request?
Similar patch to #24748 but applied to the branch-2.4.
Backporting the fix to releases 2.4.x.