Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EC2] Factor out Mesos spark-ec2 branch #3008

Closed
wants to merge 1 commit into from
Closed

[EC2] Factor out Mesos spark-ec2 branch #3008

wants to merge 1 commit into from

Conversation

nchammas
Copy link
Contributor

We reference a specific branch in two places. This patch makes it one place.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22504/
Test FAILed.

@nchammas
Copy link
Contributor Author

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22507 has started for PR 3008 at commit 10a6089.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 30, 2014

Test build #22507 has finished for PR 3008 at commit 10a6089.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22507/
Test PASSed.

@nchammas
Copy link
Contributor Author

cc @shivaram @JoshRosen

@shivaram
Copy link
Contributor

LGTM

@nchammas
Copy link
Contributor Author

nchammas commented Nov 3, 2014

cc @JoshRosen @pwendell for final review / merging.

@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2014

Actually this is a pretty small change -- I just merged this

@asfgit asfgit closed this in 2aca97c Nov 3, 2014
@nchammas
Copy link
Contributor Author

nchammas commented Nov 3, 2014

Word. Thanks @shivaram.

@nchammas nchammas deleted the mesos-spark-ec2-branch branch November 3, 2014 17:06
@marmbrus
Copy link
Contributor

marmbrus commented Nov 3, 2014

Just checking, was it intended to leave this out of 1.2?

@shivaram
Copy link
Contributor

shivaram commented Nov 3, 2014

Not really. It was just merged after the deadline. I don't think its crucial to have this in 1.2 as its mostly a style change and not a functionality change

asfgit pushed a commit that referenced this pull request Nov 5, 2014
@nchammas @pwendell
[EC2] Factor out Mesos spark-ec2 branch
b27d7dc 
We reference a specific branch in two places. This patch makes it one place.

Author: Nicholas Chammas <[email protected]>

Closes #3008 from nchammas/mesos-spark-ec2-branch and squashes the following commits:

10a6089 [Nicholas Chammas] factor out mess spark-ec2 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nchammas @AmplabJenkins @SparkQA @shivaram @marmbrus