Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-1.0][SPARK-4148][PySpark] fix seed distribution and add some tests for rdd.sample #3106

Closed
wants to merge 1 commit into from

Conversation

mengxr
Copy link
Contributor

@mengxr mengxr commented Nov 5, 2014

Port #3010 to branch-1.0.

@SparkQA
Copy link

SparkQA commented Nov 5, 2014

Test build #22916 has started for PR 3106 at commit c834cee.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 5, 2014

Test build #22916 has finished for PR 3106 at commit c834cee.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22916/
Test FAILed.

@mengxr
Copy link
Contributor Author

mengxr commented Nov 5, 2014

@JoshRosen Is branch-1.0 broken?

@JoshRosen
Copy link
Contributor

@mengxr Possibly; it doesn't look like we have a Jenkins build monitoring the health of this branch. I'll see about setting one up.

@davies
Copy link
Contributor

davies commented Nov 6, 2014

The Python tests can not pass python2.6. I think we should backport the fix or use python2.7 to test it.

@JoshRosen
Copy link
Contributor

I tried to add some builds for 1.0, but it looks like they're failing due to missing Maven dependencies:

https://amplab.cs.berkeley.edu/jenkins/job/Spark-1.0-Maven-with-YARN/2/

@davies
Copy link
Contributor

davies commented Nov 24, 2014

@mengxr Should we also backport #3351 into 1.0 / 1.1 branch?

@mengxr
Copy link
Contributor Author

mengxr commented Nov 25, 2014

#3351 is not a bug fix. So maybe we can skip 1.0 and 1.1.

@davies
Copy link
Contributor

davies commented Nov 25, 2014

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 19, 2014

Test build #24611 has started for PR 3106 at commit c834cee.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 19, 2014

Test build #24611 has finished for PR 3106 at commit c834cee.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24611/
Test FAILed.

@JoshRosen
Copy link
Contributor

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Dec 19, 2014

Test build #24619 has started for PR 3106 at commit c834cee.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 19, 2014

Test build #24619 has finished for PR 3106 at commit c834cee.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24619/
Test PASSed.

@JoshRosen
Copy link
Contributor

This passes tests, so I'm going to merge it into branch-1.0. I think this finishes the backports for this patch, so I'll resolve the JIRA issue.

@mengxr Do you mind closing this PR now, since GitHub can't auto-close it? Thanks!

asfgit pushed a commit that referenced this pull request Dec 19, 2014
…tests for rdd.sample

Port #3010 to branch-1.0.

Author: Xiangrui Meng <[email protected]>

Closes #3106 from mengxr/SPARK-4148-1.0 and squashes the following commits:

c834cee [Xiangrui Meng] apply SPARK-4148 to branch-1.0
@mengxr mengxr closed this Dec 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants